Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll goldctl forward #46771

Merged
auto-submit merged 1 commit into from
Oct 11, 2023
Merged

Roll goldctl forward #46771

auto-submit merged 1 commit into from
Oct 11, 2023

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Oct 11, 2023

@zanderso zanderso requested a review from vashworth October 11, 2023 14:30
kjlubick
kjlubick approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@kjlubick kjlubick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Piinks

vashworth
vashworth reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it on macOS 13 and it appears to have fixed the issue! Thank you @zanderso!

https://chromium-swarm.appspot.com/task?id=6537fecff3544710

Should we also update the goldctl version here?

engine/lib/web_ui/dev/generate_builder_json.dart

Line 152 in ec1d0d6

'version': 'git_revision:3a77d0b12c697a840ca0c7705208e8622dc94603',

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 11, 2023
@zanderso
Copy link
Member Author

zanderso commented Oct 11, 2023

Ran it on macOS 13 and it appears to have fixed the issue! Thank you @zanderso!

Great!

Should we also update the goldctl version here?

Yes =) Thanks. I had made that change locally and forgot to push it.

Piinks
Piinks approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!
We should probably create a cadence for rolling this forward more regularly. We pinned it since sometimes goldctl would (rarely) have a bad build and then we would then be broken in the meantime. @godofredoc do we have other systems in place that roll dependencies forward like this?

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023
@auto-submit auto-submit bot merged commit 65226ab into flutter:main Oct 11, 2023
@vashworth vashworth mentioned this pull request Oct 11, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
65226ab Roll goldctl forward (flutter/engine#46771)
45dab7c
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 68a8ff7 to ed67e8a (2 revisions) (#136383)
ea8c630 
flutter/engine@68a8ff7...ed67e8a

2023-10-11 [email protected] Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778)
2023-10-11 [email protected] Roll goldctl forward (flutter/engine#46771)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@zanderso @harryterkelsen
Roll goldctl forward (#46771)
f7acc5d 
For flutter/flutter#135620
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@vashworth vashworth vashworth left review comments

@kjlubick kjlubick kjlubick approved these changes

@Piinks Piinks Piinks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @kjlubick @vashworth @Piinks