Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Flutter 1.22.0-12.2.pre engine cherrypicks #21366

Merged
christopherfujino merged 8 commits into from
Sep 24, 2020
Merged

Flutter 1.22.0-12.2.pre engine cherrypicks #21366

christopherfujino merged 8 commits into from
Sep 24, 2020

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Sep 23, 2020 •
edited
Loading

Scheduled Cherrypicks

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 23, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master September 23, 2020 20:52
@christopherfujino christopherfujino marked this pull request as draft September 23, 2020 20:52
@auto-assign auto-assign bot requested a review from gaaclarke September 23, 2020 20:52
@christopherfujino christopherfujino removed the request for review from gaaclarke September 23, 2020 20:54
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 September 23, 2020 20:54
@christopherfujino christopherfujino changed the title Update 1.22 engine to use Dart 2.10.0-110.5.beta Flutter 1.22.0-12.1.pre engine cherrypicks Sep 23, 2020
@christopherfujino christopherfujino marked this pull request as ready for review September 23, 2020 21:27
@auto-assign auto-assign bot requested a review from gw280 September 23, 2020 21:28
jmagman
jmagman approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter/flutter#66161 and flutter/flutter#66491 LGTM

@christopherfujino christopherfujino changed the title Flutter 1.22.0-12.1.pre engine cherrypicks Flutter 1.22.0-12.2.pre engine cherrypicks Sep 23, 2020
pcsosinski
pcsosinski approved these changes Sep 23, 2020
View reviewed changes
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 23, 2020

Everything green except a "Mac iOS Engine" failure during "Scenario App Integration Test":

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8868329632012433952/+/steps/Scenario_App_Integration_Tests/0/stdout

Investigating...

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 23, 2020

Passed on re-run.

@cyanglaz
Copy link
Contributor

cyanglaz commented Sep 24, 2020

flutter/flutter#66026 LGTM

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 24, 2020

@chinmaygarde @xster @timsneath @jason-simmons @blasten could you PTAL at the relevant cherrypicks?

@xster
Copy link
Member

xster commented Sep 24, 2020

LGTM. Thank you Chris

@christopherfujino christopherfujino merged commit f763b5b into flutter:flutter-1.22-candidate.12 Sep 24, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch September 24, 2020 20:03
@christopherfujino christopherfujino mentioned this pull request Sep 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@xster xster Awaiting requested review from xster

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

5 more reviewers

@jmagman jmagman jmagman approved these changes

@blasten blasten blasten approved these changes

@timsneath timsneath timsneath approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

@pcsosinski pcsosinski pcsosinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@christopherfujino @cyanglaz @xster @jmagman @blasten @timsneath @jason-simmons @pcsosinski @googlebot @GaryQian