Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Dark mode friendly iOS debugging message #21277

Merged
fluttergithubbot merged 2 commits into from
Sep 21, 2020
Merged

Dark mode friendly iOS debugging message #21277

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f522d11
Dark mode friendly iOS debugging message
jmagman Sep 19, 2020
ac5f6cc
UIColor.systemBackgroundColor
jmagman Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ - (void)pushRoute:(NSString*)route {
messageLabel.textAlignment = NSTextAlignmentCenter;
messageLabel.autoresizingMask =
UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
messageLabel.textColor = UIColor.blackColor;
Copy link
Member

@xster xster Sep 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/optional: tiny upgrade to consider: UIColor.label here and UIColor.systemBackground on line 329 (to make this whole warning dark mode compatible)

Copy link
Member

@chinmaygarde chinmaygarde Sep 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. You could also make the container have UIColor.systemBackgroundColor and the label take UIColor.labelColor to be fully dark-mode compatible. Don't forget to put the the setters behind an @available(iOS 13.whatever) if you do though.

Copy link
Member Author

@jmagman jmagman Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to make the container background systemBackgroundColor. I didn't bother making the label black on <iOS 13 since this label only shows up on iOS 14 and later.
Updated the description screenshot.
I don't think I need to specify the labelColor, that's the default, right?

messageLabel.text =
@"In iOS 14+, Flutter application in debug mode can only be launched from Flutter tooling, "
@"IDEs with Flutter plugins or from Xcode.\n\nAlternatively, build in profile or release "
Expand Down