Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@iskakaushik
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from gaaclarke January 22, 2020 01:31
@iskakaushik iskakaushik requested a review from cbracken January 22, 2020 01:31
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@dnfield
Copy link
Contributor

dnfield commented Jan 22, 2020

I'm going to land this on red once a CI update goes through to kick infra, since it has no impact on code.

@dnfield dnfield merged commit 46e58b9 into flutter:master Jan 22, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 23, 2020
flutter/engine@83a64b7...46e58b9

git log 83a64b7..46e58b9 --first-parent --oneline
2020-01-22 [email protected] [bots] remove auto-assign for web PRs (flutter/engine#15878)
2020-01-22 [email protected] [fuchsia] HitTesting for fuchsia a11y (flutter/engine#15570)
2020-01-22 [email protected] Roll src/third_party/skia 808f021b51df..d59053987a27 (4 commits) (flutter/engine#15882)
2020-01-22 [email protected] Roll src/third_party/dart 4ad5fab95753..439cabaec02f (2 commits) (flutter/engine#15881)
2020-01-22 [email protected] Roll src/third_party/skia 4277f0173657..808f021b51df (7 commits) (flutter/engine#15879)
2020-01-22 [email protected] Remove unused Imports and private method (flutter/engine#15872)
2020-01-22 [email protected] Roll src/third_party/dart ef0c7f16e609..4ad5fab95753 (41 commits) (flutter/engine#15875)
2020-01-22 [email protected] Add missing include in GLFW and Windows embeddings (flutter/engine#15867)
2020-01-22 [email protected] Roll fuchsia/sdk/core/linux-amd64 from p1UDn... to v-OJE... (flutter/engine#15874)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
jonahwilliams pushed a commit to jonahwilliams/flutter that referenced this pull request Jan 24, 2020
flutter/engine@83a64b7...46e58b9

git log 83a64b7..46e58b9 --first-parent --oneline
2020-01-22 [email protected] [bots] remove auto-assign for web PRs (flutter/engine#15878)
2020-01-22 [email protected] [fuchsia] HitTesting for fuchsia a11y (flutter/engine#15570)
2020-01-22 [email protected] Roll src/third_party/skia 808f021b51df..d59053987a27 (4 commits) (flutter/engine#15882)
2020-01-22 [email protected] Roll src/third_party/dart 4ad5fab95753..439cabaec02f (2 commits) (flutter/engine#15881)
2020-01-22 [email protected] Roll src/third_party/skia 4277f0173657..808f021b51df (7 commits) (flutter/engine#15879)
2020-01-22 [email protected] Remove unused Imports and private method (flutter/engine#15872)
2020-01-22 [email protected] Roll src/third_party/dart ef0c7f16e609..4ad5fab95753 (41 commits) (flutter/engine#15875)
2020-01-22 [email protected] Add missing include in GLFW and Windows embeddings (flutter/engine#15867)
2020-01-22 [email protected] Roll fuchsia/sdk/core/linux-amd64 from p1UDn... to v-OJE... (flutter/engine#15874)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants