This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing include in GLFW and Windows embeddings #15867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an error caught by VS 2019.
franciscojma86
approved these changes
Jan 21, 2020
stuartmorgan-g
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
This was referenced Jan 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2020
flutter/engine@83a64b7...46e58b9 git log 83a64b7..46e58b9 --first-parent --oneline 2020-01-22 [email protected] [bots] remove auto-assign for web PRs (flutter/engine#15878) 2020-01-22 [email protected] [fuchsia] HitTesting for fuchsia a11y (flutter/engine#15570) 2020-01-22 [email protected] Roll src/third_party/skia 808f021b51df..d59053987a27 (4 commits) (flutter/engine#15882) 2020-01-22 [email protected] Roll src/third_party/dart 4ad5fab95753..439cabaec02f (2 commits) (flutter/engine#15881) 2020-01-22 [email protected] Roll src/third_party/skia 4277f0173657..808f021b51df (7 commits) (flutter/engine#15879) 2020-01-22 [email protected] Remove unused Imports and private method (flutter/engine#15872) 2020-01-22 [email protected] Roll src/third_party/dart ef0c7f16e609..4ad5fab95753 (41 commits) (flutter/engine#15875) 2020-01-22 [email protected] Add missing include in GLFW and Windows embeddings (flutter/engine#15867) 2020-01-22 [email protected] Roll fuchsia/sdk/core/linux-amd64 from p1UDn... to v-OJE... (flutter/engine#15874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
jonahwilliams
pushed a commit
to jonahwilliams/flutter
that referenced
this pull request
Jan 24, 2020
flutter/engine@83a64b7...46e58b9 git log 83a64b7..46e58b9 --first-parent --oneline 2020-01-22 [email protected] [bots] remove auto-assign for web PRs (flutter/engine#15878) 2020-01-22 [email protected] [fuchsia] HitTesting for fuchsia a11y (flutter/engine#15570) 2020-01-22 [email protected] Roll src/third_party/skia 808f021b51df..d59053987a27 (4 commits) (flutter/engine#15882) 2020-01-22 [email protected] Roll src/third_party/dart 4ad5fab95753..439cabaec02f (2 commits) (flutter/engine#15881) 2020-01-22 [email protected] Roll src/third_party/skia 4277f0173657..808f021b51df (7 commits) (flutter/engine#15879) 2020-01-22 [email protected] Remove unused Imports and private method (flutter/engine#15872) 2020-01-22 [email protected] Roll src/third_party/dart ef0c7f16e609..4ad5fab95753 (41 commits) (flutter/engine#15875) 2020-01-22 [email protected] Add missing include in GLFW and Windows embeddings (flutter/engine#15867) 2020-01-22 [email protected] Roll fuchsia/sdk/core/linux-amd64 from p1UDn... to v-OJE... (flutter/engine#15874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error caught by VS 2019.
Needed for flutter/flutter#48831