Skip to content

fix: correct parameter name from client_certAuth to client_cert_auth #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cw-Guo merged 2 commits into from
Dec 11, 2025
Merged

fix: correct parameter name from client_certAuth to client_cert_auth #1820

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ba90dd
fix: correct parameter name from client_certAuth to client_cert_auth
hs0303kr Dec 10, 2025
585d312
fix: correct parameter name from ca_certPath to ca_cert_path
hs0303kr Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/fluentd/v1alpha1/plugins/common/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func (t *Transport) Params(_ plugins.SecretLoader) (*params.PluginStore, error)
ps.InsertPairs("private_key_passphrase", fmt.Sprint(*t.PrivateKeyPassphrase))
}
if t.ClientCertAuth != nil {
ps.InsertPairs("client_certAuth", fmt.Sprint(*t.ClientCertAuth))
ps.InsertPairs("client_cert_auth", fmt.Sprint(*t.ClientCertAuth))
}
if t.CaCertPath != nil {
ps.InsertPairs("ca_certPath", fmt.Sprint(*t.CaCertPath))
Copy link
Collaborator

@cw-Guo cw-Guo Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hs0303kr would you mind fixing this too?

see https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin_helper/server.rb#L308

Copy link
Contributor Author

@hs0303kr hs0303kr Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cw-Guo Fixed!

Expand Down
Loading