fix: correct parameter name from client_certAuth to client_cert_auth #1820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fluent#1819 Signed-off-by: hs0303kr <[email protected]>
cw-Guo
requested changes
Dec 10, 2025
| ps.InsertPairs("client_cert_auth", fmt.Sprint(*t.ClientCertAuth)) | ||
| } | ||
| if t.CaCertPath != nil { | ||
| ps.InsertPairs("ca_certPath", fmt.Sprint(*t.CaCertPath)) |
Fix review comments for fluent#1819 Signed-off-by: hs0303kr <[email protected]>
cw-Guo
approved these changes
Dec 11, 2025
Collaborator
|
@hs0303kr Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes incorrect parameter naming in the Transport plugin. The parameter
client_certAuthwas using camelCase instead of snake_case, which caused TLS mutual authentication to fail because Fluentd doesn't recognize the incorrectly named parameter.Which issue(s) this PR fixes:
Fixes #1819
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: