Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| yield chalk.yellow( | ||
| `⚠️ Additionally found ${pluralize(diagnostics.length, "diagnostic")}:`, | ||
| ); |
There was a problem hiding this comment.
We should either make an ESLint rule for this like node-style-text does or switch to Ansis which handles this correctly.
| "scripts": { | ||
| "build": "tsdown", | ||
| "flint": "node --conditions='@flint.fyi/source' packages/flint/bin/index.js", | ||
| "flint:cache-ignore": "node --conditions='@flint.fyi/source' packages/flint/bin/index.js --cache-ignore", |
There was a problem hiding this comment.
I was using Zed, and it needed a package.json script to launch debugging correctly.
| log( | ||
| "Adding %d directives for file %s", | ||
| fileMetadata.directives, | ||
| fileMetadata.directives.length, |
There was a problem hiding this comment.
Otherwise it logs NaN.
| { | ||
| files: "packages/cli/src/**/*", | ||
| rules: [ | ||
| ts.rules({ | ||
| consoleCalls: false, | ||
| }), | ||
| ], | ||
| }, |
There was a problem hiding this comment.
@barrymichaeldoyle, you've been working in a tangentially-related area, what are your thoughts on surfacing a Knip-style config hint for this? I think it's annoying that we didn't get a warning but on the other hand, it'd potentially make composing configs really annoying.
There was a problem hiding this comment.
I personally prefer the idea of the Knip-style config hint 😁 Not sure how annoying it could make composing configs though. If it were up to me, I'd do it and revert later if it's too annoying.
Otherwise RuleCreator'd rule no longer have an id, breaking intellisense & excess property checks for `.rules()`.
| >, | ||
| ): Rule< | ||
| RuleAboutWithPresetsAndUrl<Presets>, | ||
| // We can't put this in the constraint or else inference fails for some reason. |
There was a problem hiding this comment.
AKA I revived #1418. Not sure what's up with that.
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Thanks!
Agreed all around on the threads. They all look good to me as followups.
JoshuaKGoldberg
added
the
ready to merge
We never pass this, it isn't real, what isn't real can't hurt me until it starts failing me tests.
3 participants
PR Checklist
status: accepting prsOverview
I haven't actually tracked down #1854 yet, but I found enough other bugs I'm submitting this preliminarily, feel free to merge independently.