generated from JoshuaKGoldberg/create-typescript-app
-
Notifications
You must be signed in to change notification settings - Fork 19
Closed
Labels
package: coreRelated to the core Flint package underlying all other packages and plugins.Related to the core Flint package underlying all other packages and plugins.status: accepting prsPlease, send a pull request to resolve this! 🙏Please, send a pull request to resolve this! 🙏type: bugSomething isn't working 🐛Something isn't working 🐛
Description
Bug Report Checklist
- I am using the latest published version of all Flint packages.
- I have searched for related issues and found none that matched my issue.
Expected
Not all rules in a plugin should need to come in a preset. For example, ts.consoleCalls (#1315) isn't in any preset by default. That should be allowed.
Actual
As seen in #1413, the ts plugin became PluginPrests<About, unknown> in the type system. That caused type checking errors.
packages/site build: [@mdx-js/rollup] Plugin "expressive-code-twoslash" caused an error in its "preprocessCode" hook. Error message:
packages/site build: ## Errors were thrown in the sample, but not included in an error tag
packages/site build: These errors were not marked as being expected: 2339.
packages/site build: Expected: // @errors: 2339
packages/site build: Compiler Errors:
packages/site build: index.ts
packages/site build: [2339] 139 - Property 'logical' does not exist on type 'PluginPresets<RuleAbout, unknown>'.
Additional Info
Whether ts.consoleCalls should be moved into logicalStrict is a separate discussion from this issue.
❤️🔥
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
package: coreRelated to the core Flint package underlying all other packages and plugins.Related to the core Flint package underlying all other packages and plugins.status: accepting prsPlease, send a pull request to resolve this! 🙏Please, send a pull request to resolve this! 🙏type: bugSomething isn't working 🐛Something isn't working 🐛