-
Notifications
You must be signed in to change notification settings - Fork 14
chore: add 'propose-downstrem' job for CentOS #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: add 'propose-downstrem' job for CentOS #138
Conversation
Signed-off-by: Miguel Martín <[email protected]>
Summary of ChangesHello @mmartinv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous delivery pipeline by introducing an automated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a propose_downstream job for CentOS to the Packit configuration. The change for Fedora adds a helpful documentation link. The new job for CentOS includes configuration to synchronize branches between CentOS Stream 9 and 10. My review identifies a potential issue with the branch synchronization logic, where changes from a newer stream (c10s) are proposed to be fast-forwarded to an older stream (c9s). I've suggested reversing this to follow the more common and safer practice of merging from older to newer streams.
| c10s: | ||
| fast_forward_merge_into: ["c9s"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current dist_git_branches configuration attempts to fast-forward merge changes from CentOS Stream 10 (c10s) into CentOS Stream 9 (c9s). This is an unusual workflow, as it pushes changes from a newer release stream to an older one. This could unintentionally introduce breaking changes or features that are not compatible with the older environment of c9s.
The conventional approach is to manage changes in the oldest supported branch and fast-forward them to newer branches. This ensures that a change is compatible with the older environment first. I'd recommend reversing the logic to apply changes to c9s and fast-forward them into c10s.
c9s:
fast_forward_merge_into: ["c10s"]
Signed-off-by: Miguel Martín [email protected]