Skip to content

chore: add 'propose-downstrem' job for CentOS #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: add 'propose-downstrem' job for CentOS #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .packit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ jobs:
- "fedora-eln-aarch64"

# Only Fedora >= 43 have golang >= 1.25.0
# https://packit.dev/docs/configuration/upstream/propose_downstream
- job: propose_downstream
trigger: release
packages: [go-fdo-server-fedora]
Expand Down Expand Up @@ -151,6 +152,16 @@ jobs:
- "epel-10-x86"
- "epel-10-aarch64"

# https://packit.dev/docs/configuration/upstream/propose_downstream#syncing-the-release-to-centos-stream
- job: propose_downstream
trigger: release
packages: [go-fdo-server-centos]
# Avoid divergent branches: https://packit.dev/docs/fedora-releases-guide/non-divergent-dist-git-branches
dist_git_branches:
c10s:
fast_forward_merge_into: ["c9s"]
Comment on lines +161 to +162
Copy link

@gemini-code-assist gemini-code-assist bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current dist_git_branches configuration attempts to fast-forward merge changes from CentOS Stream 10 (c10s) into CentOS Stream 9 (c9s). This is an unusual workflow, as it pushes changes from a newer release stream to an older one. This could unintentionally introduce breaking changes or features that are not compatible with the older environment of c9s.

The conventional approach is to manage changes in the oldest supported branch and fast-forward them to newer branches. This ensures that a change is compatible with the older environment first. I'd recommend reversing the logic to apply changes to c9s and fast-forward them into c10s.

      c9s:
        fast_forward_merge_into: ["c10s"]



# CentOS E2E Testing jobs
#
- job: tests
Expand Down
Loading