Rework component testing support to make test updates easier#395
Merged
Conversation
Merged
jameysharp
approved these changes
Jun 28, 2024
Contributor
jameysharp
left a comment
There was a problem hiding this comment.
Yup, this strikes me as a net positive for test clarity, in spite of my general preference to avoid macros. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a macro for generating the core wasm and component versions of a test, and
modify the
.adapt_componentbuilder function onTestto accept a bool. Thissimplifies modifying existing tests to support components by doing the work of
abstracting out the body in a macro.