Run tests as components#396
Merged
Merged
Conversation
elliottt
force-pushed
the
trevor/component-tests-1
branch
5 times, most recently
from
679bc21 to
3c3d4a4
Compare
elliottt
force-pushed
the
trevor/component-tests-1
branch
from
3c3d4a4 to
191a07c
Compare
acw
requested changes
Jul 2, 2024
Contributor
acw
left a comment
acw
left a comment
There was a problem hiding this comment.
I'd like to see if the serial thing can work out, to help us understand what's breaking. But if it doesn't, then ping me and I'll approve without it.
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
Update tests to run as both core-wasm modules and components. This also includes a number of fixes to both the component adapter and component host side implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tests to run as both core-wasm modules and components. This also includes a number of fixes to both the component adapter and component host side implementation.