Skip to content

do not panic on calls to auto_decompress_response_set which are not setting the decompression to gzip#116

Merged
cratelyn merged 4 commits into
fastly:mainfrom
JakeChampion:compress
Jan 11, 2022
Merged

do not panic on calls to auto_decompress_response_set which are not setting the decompression to gzip#116
cratelyn merged 4 commits into
fastly:mainfrom
JakeChampion:compress

Conversation

@JakeChampion
Copy link
Copy Markdown
Contributor

@JakeChampion JakeChampion commented Jan 11, 2022

I've added two tests, one which set the decompression to the default value - this should not cause a panic, and another test which sets the decompression to gzip - this should cause a panic due to it being unimplemented.

This aims to resolve #115

Comment thread test-fixtures/src/bin/request.rs Outdated
@JakeChampion JakeChampion requested a review from cratelyn January 11, 2022 16:32
Copy link
Copy Markdown

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✔️

@cratelyn cratelyn merged commit 45c2406 into fastly:main Jan 11, 2022
@cratelyn cratelyn mentioned this pull request Jan 11, 2022
@JakeChampion JakeChampion deleted the compress branch February 23, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auto_decompress_response_set has not yet been implemented in Viceroy

2 participants