auto_decompress_response_set has not yet been implemented in Viceroy

[StarpTech]

Hello, we run into

 panicked at 'not implemented: auto_decompress_response_set has not yet been implemented in Viceroy', /home/starptech/.cargo/registry/src/github.zerozr99.workers.dev-1ecc6299db9ec823/viceroy-lib-0.2.8/src/wiggle_abi/req_impl.rs:476:9

     // Build client request
        let req = hyper::Request::builder()
            .method(Method::POST)
            .uri("http://example.com")
            .header("authorization", "bearer 123")
            .header("content-type", "application/json")
            .body(Body::from(serde_json::to_string(client_json_body).unwrap()))
            .unwrap();

        // Fire request
        let response = viceroy::handle_request(req, url).await.unwrap();

when upgrading from "fastly: 0.8.0" to "fastly: 0.8.1"

It will internally update

[[package]]
name = "fastly-shared"
version = "0.8.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a50fae8c678779e8dcd18e36f9982d09c706764e8976c542fd53193a62d83727"
dependencies = [
 "bitflags",
 "http",
 "thiserror",
]

[[package]]
name = "fastly-sys"
version = "0.8.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "afcf0f870a0c9ac8166b0797a9391e5df81b7b5cc13b53b4d305e0b1368801d4"
dependencies = [
 "bitflags",
 "fastly-shared 0.8.1",
]

It was introduced in fee8165

Related: fastly/cli#496

[cratelyn]

hello @StarpTech! could you check which version of Viceroy that you are running? fee8165 (see #113), and the subsequent 0.2.8 release (see #114) should have fixed this issue, which was raised by changes in the 0.8.1 SDK release.

could you try running viceroy --version to confirm that you are seeing this even when running 0.2.8?

[JakeChampion]

Howdy @cratelyn - I'm also seeing the same issue when using Viceroy version 0.2.8 and Fastly 0.8.1

I think this could be fixed removing the unimplemented! call in the below function:

Viceroy/lib/src/wiggle_abi/req_impl.rs

Lines 471 to 478 in 264e71e

	fn auto_decompress_response_set(
	&mut self,
	_h: RequestHandle,
	_encodings: ContentEncodings,
	) -> Result<(), Error> {
	unimplemented!("auto_decompress_response_set has not yet been implemented in Viceroy");
	}
	}

[cratelyn]

ah! i see, this is indeed a problem with that stub. upon inspecting the fastly crate, i see that this auto_decompress_response_set function is called in a common code path. (here: https://docs.rs/fastly/latest/src/fastly/http/request.rs.html#2039)

i believe you are correct @JakeChampion, the best temporary solution for now would be to stub this out with an Ok(()) no-op, instead of the unimplemented! we can use for other unimplemented hostcalls.

[aturon]

A suggestion: we could make the behavior dependent on which ContentEncodings are present, i.e. use unimplemented!() only if the call is trying to use gzip, until that piece is implemented.

[JakeChampion]

I've created a pull-request which implements the suggestion made by @aturon ☺️
#116

[cratelyn]

cc: @StarpTech @JakeChampion

a new v0.2.9 release has been published that addresses this issue. thank you for bringing this to our attention, and to Jake for implementing the fix! you can also find the new versions of viceroy-lib and viceroy on crates.io.