Closed
Conversation
This was referenced Jul 2, 2022
Owner
Author
|
@stepanblyschak please review |
6 tasks
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
* Add EEPROM_INFO table * Add FAN_INFO table * Add TEMPERATURE_INFO table * Add PSU_INFO table Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
fastiuk
force-pushed
the
login-message-config
branch
from
83ccd09 to
4dcb074
Compare
|
@fastiuk Please update PR to include only your changes |
Owner
Author
Done |
Comment on lines
+475
to
+478
| #define STATE_EEPROM_INFO_TABLE_NAME "EEPROM_INFO" | ||
| #define STATE_FAN_INFO_TABLE_NAME "FAN_INFO" | ||
| #define STATE_TEMPERATURE_INFO_TABLE_NAME "TEMPERATURE_INFO" | ||
| #define STATE_PSU_INFO_TABLE_NAME "PSU_INFO" |
There was a problem hiding this comment.
These lines are not related to log message config
Owner
Author
There was a problem hiding this comment.
Yes, it doesn't.
That is why I put it in a separate commit.
| #define CFG_LAG_INTF_TABLE_NAME "PORTCHANNEL_INTERFACE" | ||
| #define CFG_VLAN_INTF_TABLE_NAME "VLAN_INTERFACE" | ||
| #define CFG_VLAN_SUB_INTF_TABLE_NAME "VLAN_SUB_INTERFACE" | ||
| #define CFG_MGMT_PORT_TABLE_NAME "MGMT_PORT" |
There was a problem hiding this comment.
This line is not related to log message config
Owner
Author
There was a problem hiding this comment.
Yes, it doesn't.
That is why I put it in a separate commit.
There was a problem hiding this comment.
The PR title is "Login messages config". SONiC community requires to divide different features contribution into different PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on fastiuk/sonic-buildimage#4
Why I did it
How to verify it
Build SONiC
or
When SONiC was already built:
Login into the switch.
Set messages:
Logout/login and see the results:
Clear messages:
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
sonic-login_message.yang
Superproject PR:
A picture of a cute animal