Closed
Conversation
fastiuk
force-pushed
the
login-message-config
branch
from
da4a086 to
f16caec
Compare
* Handle pre-login message. * Handle post-login message. Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
login-message-config
branch
from
f16caec to
a6a6215
Compare
This was referenced Jul 29, 2022
Owner
Author
|
@stepanblyschak please review |
stepanblyschak
suggested changes
Oct 25, 2022
Comment on lines
+1276
to
+1279
| self.cache['pre-login'] = login_msgs.get('pre-login',{} | ||
| ).get('message', '') | ||
| self.cache['post-login'] = login_msgs.get('post-login', {} | ||
| ).get('message', '') |
There was a problem hiding this comment.
Suggested change
| self.cache['pre-login'] = login_msgs.get('pre-login',{} | |
| ).get('message', '') | |
| self.cache['post-login'] = login_msgs.get('post-login', {} | |
| ).get('message', '') | |
| self.cache['pre-login'] = login_msgs.get('pre-login', {}).get('message', '') | |
| self.cache['post-login'] = login_msgs.get('post-login', {}).get('message', '') |
Owner
Author
There was a problem hiding this comment.
The total line width will exceed 80 chars. Which will break python code style
There was a problem hiding this comment.
There are lines longer then 80 chars in this file. We don't follow that guideline and a newline in the middle hurts readability.
| login_msgs = self.config_db.get_table( | ||
| swsscommon.CFG_LOGIN_MESSAGE_TABLE_NAME) | ||
| for key in login_msgs: | ||
| self.loginmsgcfg.set_login_message(key, login_msgs[key]) |
There was a problem hiding this comment.
load will save configuration into the cache, so this call to set_login_message will not set anything because it is the same as in the cache?
Comment on lines
+1294
to
+1297
| msg = None if not isinstance(data, dict) else data.get('message') | ||
| if type(msg) != str: | ||
| # Nothing to handle | ||
| return |
There was a problem hiding this comment.
Suggested change
| msg = None if not isinstance(data, dict) else data.get('message') | |
| if type(msg) != str: | |
| # Nothing to handle | |
| return | |
| msg = data.get('message') | |
| if not msg: | |
| # Nothing to handle | |
| return |
| if key == 'pre_login': | ||
| # Write pre-login to /etc/issue file | ||
| run_cmd(self.cmds.login_message_pre.format(not_newline, msg), | ||
| True, True) |
There was a problem hiding this comment.
add log_err and raise_exception as you do on next lines for readability
|
|
||
| class LoginCfg(object): | ||
| """ | ||
| LoginCfg Config Daemon |
There was a problem hiding this comment.
The Daemon word confuses since it is not a deamon
| "modify pam_limits config file failed with exception: {}" | ||
| .format(e)) | ||
|
|
||
| class LoginCfg(object): |
There was a problem hiding this comment.
No need in python3:
Suggested change
| class LoginCfg(object): | |
| class LoginCfg: |
Comment on lines
+1260
to
+1261
| Handles changes in LOGIN_MESSAGE table. | ||
| 1) Handle change for pre-login and post-login messages. |
There was a problem hiding this comment.
Suggested change
| Handles changes in LOGIN_MESSAGE table. | |
| 1) Handle change for pre-login and post-login messages. | |
| Handles changes in LOGIN_MESSAGE table for pre-login and post-login messages. |
Comment on lines
+1287
to
+1291
| cache: Cache to compare/save data. | ||
| db: DB instance. | ||
| table: DB table that was changed. | ||
| key: DB table's key that was triggered change. | ||
| data: Read table data. |
There was a problem hiding this comment.
Suggested change
| cache: Cache to compare/save data. | |
| db: DB instance. | |
| table: DB table that was changed. | |
| key: DB table's key that was triggered change. | |
| data: Read table data. | |
| key: DB table's key that was triggered change. | |
| data: Read table data. |
|
Requires UT |
fastiuk
pushed a commit
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Gang Lv [email protected] Why I did it GNMI needs to use host service to invoke generic_config_updater and config reload. How I did it Add host_modules for generic_config_updater and config reload. Add unit test for host modules. How to verify it Run unit test for sonic-host-services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on fastiuk/sonic-buildimage#4
Why I did it
How to verify it
Build SONiC
or
When SONiC was already built:
Login into the switch.
Set messages:
Logout/login and see the results:
Clear messages:
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
sonic-login_message.yang
Superproject PR:
A picture of a cute animal