Fix OSS build cpp_include path handling#462
Open
charles-typ wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Fix OSS build cpp_include path handling#462charles-typ wants to merge 1 commit intofacebookresearch:v2-betafrom
charles-typ wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@charles-typ has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92609819. |
charles-typ
added a commit
to charles-typ/DCPerf
that referenced
this pull request
Feb 23, 2026
Summary: The OSS build install script was missing sed handling for `cpp_include` directives in Thrift files, which caused build failures when the thrift compiler processed `UcacheBenchService.thrift` with hardcoded internal fbcode paths. Reviewed By: excelle08 Differential Revision: D92609819
charles-typ
force-pushed
the
export-D92609819-to-v2-beta
branch
from
3dc56a7 to
e0c4482
Compare
charles-typ
added a commit
to charles-typ/DCPerf
that referenced
this pull request
Mar 1, 2026
Summary: The OSS build install script was missing sed handling for `cpp_include` directives in Thrift files, which caused build failures when the thrift compiler processed `UcacheBenchService.thrift` with hardcoded internal fbcode paths. Reviewed By: excelle08 Differential Revision: D92609819
charles-typ
force-pushed
the
export-D92609819-to-v2-beta
branch
from
e0c4482 to
72978e1
Compare
charles-typ
added a commit
to charles-typ/DCPerf
that referenced
this pull request
Mar 1, 2026
Summary: The OSS build install script was missing sed handling for `cpp_include` directives in Thrift files, which caused build failures when the thrift compiler processed `UcacheBenchService.thrift` with hardcoded internal fbcode paths. Reviewed By: excelle08 Differential Revision: D92609819
charles-typ
force-pushed
the
export-D92609819-to-v2-beta
branch
from
72978e1 to
07c70e6
Compare
Summary: Pull Request resolved: facebookresearch#462 The OSS build install script was missing sed handling for `cpp_include` directives in Thrift files, which caused build failures when the thrift compiler processed `UcacheBenchService.thrift` with hardcoded internal fbcode paths. Reviewed By: excelle08 Differential Revision: D92609819
charles-typ
force-pushed
the
export-D92609819-to-v2-beta
branch
from
07c70e6 to
d3e56a1
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
Summary: Pull Request resolved: #462 The OSS build install script was missing sed handling for `cpp_include` directives in Thrift files, which caused build failures when the thrift compiler processed `UcacheBenchService.thrift` with hardcoded internal fbcode paths. Reviewed By: excelle08 Differential Revision: D92609819 fbshipit-source-id: 09e2465c98eebf216adc87dd8e25395d1db061a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The OSS build install script was missing sed handling for
cpp_includedirectives in Thrift files, which caused build failures when the thrift compiler processedUcacheBenchService.thriftwith hardcoded internal fbcode paths.Reviewed By: excelle08
Differential Revision: D92609819