Skip to content

Commit 72978e1

Browse files
charles-typfacebook-github-bot
authored andcommitted
Fix OSS build cpp_include path handling (#462)
Summary: The OSS build install script was missing sed handling for `cpp_include` directives in Thrift files, which caused build failures when the thrift compiler processed `UcacheBenchService.thrift` with hardcoded internal fbcode paths. Reviewed By: excelle08 Differential Revision: D92609819
1 parent 6ab9029 commit 72978e1

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

packages/ucache_bench/install_ucache_bench.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -564,6 +564,8 @@ for f in "$PROTOCOL_GEN_DIR"/*.cpp "$PROTOCOL_GEN_DIR"/*.h "$PROTOCOL_GEN_DIR"/*
564564
sed -i 's|#include "cea/chips/benchpress/packages/ucache_bench/server/|#include "../server/|g' "$f"
565565
# Fix thrift include paths (for .thrift files)
566566
sed -i 's|include "cea/chips/benchpress/packages/ucache_bench/protocol/gen/|include "|g' "$f"
567+
# Fix cpp_include paths (for .thrift files)
568+
sed -i 's|cpp_include "cea/chips/benchpress/packages/ucache_bench/protocol/gen/|cpp_include "|g' "$f"
567569
fi
568570
done
569571

0 commit comments

Comments
 (0)