Revert visibility change of ReactCookieJarContainer #49247
Closed
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was incorrectly made internal in https://www.internalfb.com/diff/D66724567 Changelog: [Android][Removed] Made ReactCookieJarContainer internal. Reviewed By: cortinico, andrewdacenko Differential Revision: D69254203
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69254203 |
Contributor
|
This pull request has been merged in f25e35a. |
Collaborator
|
This pull request was successfully merged by @javache in f25e35a When will my fix make it into a release? | How to file a pick request? |
fabriziocucci
pushed a commit
that referenced
this pull request
Feb 10, 2025
Summary: Pull Request resolved: #49247 This was incorrectly made internal in https://www.internalfb.com/diff/D66724567 Changelog: [Android][Removed] Made ReactCookieJarContainer internal. Reviewed By: cortinico, andrewdacenko Differential Revision: D69254203 fbshipit-source-id: 5c4ba9b4f9a8e53002df25b55f0c8762874e6736
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#49247 This was incorrectly made internal in https://www.internalfb.com/diff/D66724567 Changelog: [Android][Removed] Made ReactCookieJarContainer internal. Reviewed By: cortinico, andrewdacenko Differential Revision: D69254203 fbshipit-source-id: 5c4ba9b4f9a8e53002df25b55f0c8762874e6736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was incorrectly made internal in https://www.internalfb.com/diff/D66724567
Changelog: [Android][Removed] Made ReactCookieJarContainer internal.
Reviewed By: cortinico, andrewdacenko
Differential Revision: D69254203