Undo a breaking change on ReactOverflowView #49229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This interface was converted to Kotlin, but the single method should have been converted to a `val`. People kotlin consumers could call ReactOverflowView.overflow; now they need to call getOverflow(). Changelog: [Internal] [Changed] - Undo a breaking change on ReactOverflowView Differential Revision: D69250226
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69250226 |
Contributor
|
This pull request has been merged in 2f784ce. |
Collaborator
|
This pull request was successfully merged by @cortinico in 2f784ce When will my fix make it into a release? | How to file a pick request? |
fabriziocucci
pushed a commit
that referenced
this pull request
Feb 10, 2025
Summary: Pull Request resolved: #49229 This interface was converted to Kotlin, but the single method should have been converted to a `val`. People kotlin consumers could call ReactOverflowView.overflow; now they need to call getOverflow(). Changelog: [Internal] [Changed] - Undo a breaking change on ReactOverflowView Reviewed By: NickGerleman Differential Revision: D69250226 fbshipit-source-id: 5c7cca8c83f5c76a9cc1d254f8aa51409150c356
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#49229 This interface was converted to Kotlin, but the single method should have been converted to a `val`. People kotlin consumers could call ReactOverflowView.overflow; now they need to call getOverflow(). Changelog: [Internal] [Changed] - Undo a breaking change on ReactOverflowView Reviewed By: NickGerleman Differential Revision: D69250226 fbshipit-source-id: 5c7cca8c83f5c76a9cc1d254f8aa51409150c356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This interface was converted to Kotlin, but the single method should have been converted to a
val.People kotlin consumers could call ReactOverflowView.overflow; now they need to call getOverflow().
Changelog:
[Internal] [Changed] - Undo a breaking change on ReactOverflowView
Differential Revision: D69250226