Skip to content

Conversation

@cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jan 13, 2025

Summary:

This change improves the E2E testing by downloading the iOS RNTesterApp that is built in CI instead of building it locally. This should let us save 10 to 20 minutes when we test a new release.

Changelog:

[Internal] - Use the RNTester app built in CI for release testing on iOS

Test Plan:

  • build the app in ci
  • run yarn test-e2e-local -c <my-token> and yarn test-e2e-local -h false -c <my-token> and verify that the iOS app is not built, but run in the simulator

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 13, 2025
@cipolleschi cipolleschi force-pushed the cipolleschi/use-rntester-app-in-release-testing branch 2 times, most recently from e6286fa to 41ae445 Compare January 14, 2025 17:50
@cipolleschi cipolleschi marked this pull request as ready for review January 14, 2025 17:50
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/use-rntester-app-in-release-testing branch from 41ae445 to fe07105 Compare January 14, 2025 17:53
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

@cipolleschi cipolleschi force-pushed the cipolleschi/use-rntester-app-in-release-testing branch from fe07105 to 89b207d Compare January 14, 2025 21:19
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 15, 2025
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 559d070.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 559d070

When will my fix make it into a release? | How to file a pick request?

fabriziocucci pushed a commit that referenced this pull request Jan 20, 2025
Summary:
This change improves the E2E testing by downloading the iOS RNTesterApp that is built in CI instead of building it locally. This should let us save 10 to 20 minutes when we test a new release.

## Changelog:
[Internal] - Use the RNTester app built in CI for release testing on iOS

Pull Request resolved: #48637

Test Plan:
- build the app in ci
- run `yarn test-e2e-local -c <my-token>` and `yarn test-e2e-local -h false -c <my-token>` and verify that the iOS app is not built, but run in the simulator

Reviewed By: cortinico

Differential Revision: D68161477

Pulled By: cipolleschi

fbshipit-source-id: 577d110f9ff0197a2d3348a08a60e60a4d0a752b
@cipolleschi cipolleschi deleted the cipolleschi/use-rntester-app-in-release-testing branch March 3, 2025 15:08
gabrieldonadel pushed a commit to gabrieldonadel/react-native that referenced this pull request Aug 12, 2025
Summary:
This change improves the E2E testing by downloading the iOS RNTesterApp that is built in CI instead of building it locally. This should let us save 10 to 20 minutes when we test a new release.

## Changelog:
[Internal] - Use the RNTester app built in CI for release testing on iOS

Pull Request resolved: facebook#48637

Test Plan:
- build the app in ci
- run `yarn test-e2e-local -c <my-token>` and `yarn test-e2e-local -h false -c <my-token>` and verify that the iOS app is not built, but run in the simulator

Reviewed By: cortinico

Differential Revision: D68161477

Pulled By: cipolleschi

fbshipit-source-id: 577d110f9ff0197a2d3348a08a60e60a4d0a752b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants