Small fixes to the READMEs and CLI help messages#426
Merged
kevinlewi merged 5 commits intofacebook:mainfrom Mar 15, 2024
haochenuw:small_fixes
Merged
Small fixes to the READMEs and CLI help messages#426kevinlewi merged 5 commits intofacebook:mainfrom haochenuw:small_fixes
kevinlewi merged 5 commits intofacebook:mainfrom
haochenuw:small_fixes
Conversation
added 2 commits
March 15, 2024 11:40
Given that the library has removed support for getting epoch hash for epochs other than the latest one, the cli in the example should be updated to reflect this change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 87.99% 88.44% +0.44%
==========================================
Files 39 39
Lines 9054 9214 +160
==========================================
+ Hits 7967 8149 +182
+ Misses 1087 1065 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Looks good, thanks! I know it's unrelated, but mind addressing the clippy error in this diff as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I