Skip to content

Small fixes to the READMEs and CLI help messages#426

Merged
kevinlewi merged 5 commits intofacebook:mainfrom
haochenuw:small_fixes
Mar 15, 2024
Merged

Small fixes to the READMEs and CLI help messages#426
kevinlewi merged 5 commits intofacebook:mainfrom
haochenuw:small_fixes

Conversation

@haochenuw
Copy link
Contributor

In this PR I

  • updated the README in the example directory to include the MySQL docker instance spin-up command.
  • updated the help message for the CLI in mysql_demo. Since it is no longer supported to get root_hash of an older epoch, I modified the description of root_hash command to remove the optional epoch parameter from the CLI help message.

Hao Chen added 2 commits March 15, 2024 11:40
Given that the library has removed support for getting epoch hash for epochs other than the latest one, the cli in the example should
be updated to reflect this change.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (24b11de) to head (1d22b5a).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   87.99%   88.44%   +0.44%     
==========================================
  Files          39       39              
  Lines        9054     9214     +160     
==========================================
+ Hits         7967     8149     +182     
+ Misses       1087     1065      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevinlewi
Copy link
Contributor

Looks good, thanks! I know it's unrelated, but mind addressing the clippy error in this diff as well?

Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants