Fix / Show selected items in combo box #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphweaver-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…moved a button that was adding nothing
|
|
Going to go ahead and merge this with known SonarQube flags around accessibility, as the current component has these same problems. We'll work on fixing those next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our UX around selected items is not great at the moment. If one item is selected, it's easy to tell which it is, but once multiple are selected then it is really hard as a user to see what you've chosen.
This PR provides a better UX for this by showing the selected items at the top of the dropdown, always scrolling to the top of the dropdown when it opens, and allowing users to individually deselect options instead of the all or nothing clear we have currently:
With 3 selected items
When hovering a selected item
This applies to the
ComboBox,RelationshipFilter, andRelationshipFieldcomponents.