Skip to content

Commit eab51e2

Browse files
committed
Implementing a tiny bit of feedback from Kevin around a keyboard event handler
1 parent 4bf3e67 commit eab51e2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/packages/admin-ui-components/src/combo-box/component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,9 +311,9 @@ export const ComboBox = ({
311311
type="button"
312312
onClick={() => !disabled && toggleMenu()}
313313
onKeyDown={(e) => {
314-
if (e.key === 'ArrowDown' && !isOpen && !disabled) {
314+
if ((e.key === 'ArrowDown' || e.key === 'Space') && !disabled) {
315315
e.preventDefault();
316-
toggleMenu();
316+
openMenu();
317317
}
318318
}}
319319
className={clsx(styles.arrow, isOpen && styles.arrowOpen)}

0 commit comments

Comments
 (0)