Skip to content

ci: fix workflow triggering on tag + matrix parameters #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morph-dev merged 1 commit into from
May 14, 2025
Merged

ci: fix workflow triggering on tag + matrix parameters #1827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 19 additions & 93 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,114 +317,40 @@ workflows:
docker-master-commit:
jobs:
- docker-build:
name: docker_build_trin
target: trin
name: docker_build__<< matrix.target >>

@KolbyML KolbyML May 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: docker_build__<< matrix.target >>
name: docker_build_<< matrix.target >>

were the double _ intentional?

@morph-dev morph-dev May 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We already have one in "docker_build" and some targets might contain "_" in the future. I figured that using two would make things clearer.

@KolbyML KolbyML May 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok 👍

tags: latest
matrix:
parameters:
target: ["trin", "bridge", "e2hs-writer", "trin-execution"]
- docker-publish:
name: docker_publish_trin
target: trin
name: docker_publish__<< matrix.target >>
requires:
- docker_build_trin
- docker_build__<< matrix.target >>
filters:
branches:
only: master
- docker-build:
name: docker_build_bridge
target: bridge
tags: latest
- docker-publish:
name: docker_publish_bridge
target: bridge
requires:
- docker_build_bridge
filters:
branches:
only: master
- docker-build:
name: docker_build_e2hs_writer
target: e2hs-writer
tags: latest
- docker-publish:
name: docker_publish_e2hs_writer
target: e2hs-writer
requires:
- docker_build_e2hs_writer
filters:
branches:
only: master
- docker-build:
name: docker_build_trin_execution
target: trin-execution
tags: latest
- docker-publish:
name: docker_publish_trin_execution
target: trin-execution
requires:
- docker_build_trin_execution
filters:
branches:
only: master
matrix:
parameters:
target: ["trin", "bridge", "e2hs-writer", "trin-execution"]
docker-master-tag:
when:
and: [ << pipeline.git.tag >>, << pipeline.git.branch.is_default >> ]
when: << pipeline.git.tag >>
jobs:
- docker-build:
name: docker_build_trin
target: trin
tags: << pipeline.git.tag >>-$(git rev-parse --short HEAD) stable prod
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
- docker-publish:
name: docker_publish_trin
requires:
- docker_build_trin
target: trin
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
- docker-build:
name: docker_build_bridge
target: bridge
tags: << pipeline.git.tag >>-$(git rev-parse --short HEAD) stable prod
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
- docker-publish:
name: docker_publish_bridge
requires:
- docker_build_bridge
target: bridge
name: docker_build__<< matrix.target >>
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
- docker-build:
name: docker_build_e2hs_writer
target: e2hs-writer
tags: << pipeline.git.tag >>-$(git rev-parse --short HEAD) stable prod
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
matrix:
parameters:
target: ["trin", "bridge", "e2hs-writer", "trin-execution"]
- docker-publish:
name: docker_publish_e2hs_writer
name: docker_publish_trin__<< matrix.target >>
requires:
- docker_build_e2hs_writer
target: e2hs-writer
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
- docker-build:
name: docker_build_trin_execution
target: trin-execution
tags: << pipeline.git.tag >>-$(git rev-parse --short HEAD) stable prod
- docker_build__<< matrix.target >>
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
- docker-publish:
name: docker_publish_trin_execution
requires:
- docker_build_trin_execution
target: trin-execution
filters:
tags:
only: /^v\d+(\.\d+){0,2}(-\w*\.\d+)?$/
matrix:
parameters:
target: ["trin", "bridge", "e2hs-writer", "trin-execution"]