ci: fix workflow triggering on tag + matrix parameters

[morph-dev]

What was wrong?

The recently updated circleci config to build and publish docker images is not triggering on tag.

This is not something that I was able to test, but I'm pretty confident that this will solve the problem.

How was it fixed?

Now I only use << pipeline.git.tag >> as a when config for a docker-master-tag workflow.

I also removed the duplication of invoking all jobs manually, and I'm using matrix jobs.

To-Do

• Clean up commit history and use conventional commits.

[KolbyML]

looks good

[KolbyML]

Suggested change

	name: docker_build__<< matrix.target >>
	name: docker_build_<< matrix.target >>

were the double _ intentional?

[morph-dev]

Yes. We already have one in "docker_build" and some targets might contain "_" in the future. I figured that using two would make things clearer.

[KolbyML]

Oh ok 👍

[carver]

Now I only use << pipeline.git.tag >> as a when config for a docker-master-tag workflow.

Just to make sure I understand the theory, the reason that the tag build was not triggering is that:

[ << pipeline.git.tag >>, << pipeline.git.branch.is_default >> ]

will never be true, because it won't simultaneously treat the event as a tag and as a branch, right?

One option is to go the route of planning other tags to look like bridge-v1.2.3 if we want to trigger tag events for different binaries.

[morph-dev]

will never be true, because it won't simultaneously treat the event as a tag and as a branch, right?

Yes, that's correct.

One option is to go the route of planning other tags to look like bridge-v1.2.3 if we want to trigger tag events for different binaries.

Yes, that would be an option. If we start doing that frequently, it would make sense to adjust circleci config to support that.
If it is one-time thing, then we can just do it manually, like we did before.