tests/4844: excessDataGas and dataGasUsed spec update
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
force-pushed
the
excess-data-gas-calc-spec-update
branch
from
d8f7c2d to
419a0bb
Compare
marioevz
changed the title
excessDataGas and dataGasUsed spec updateexcessDataGas and dataGasUsed spec update
spencer-tb
reviewed
Jun 14, 2023
spencer-tb
requested changes
Jun 14, 2023
Collaborator
spencer-tb
left a comment
spencer-tb
left a comment
There was a problem hiding this comment.
Utils file is well used :D
I will re-review after you have re-based onto Dan changes
marioevz
force-pushed
the
excess-data-gas-calc-spec-update
branch
from
419a0bb to
18b555a
Compare
Member
Author
|
@spencer-tb rebased and fixed the comment 👍 |
spencer-tb
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following spec changes:
data_gas_usedto header EIPs#7062excess_data_gasto 64 bit EIPs#7095max_fee_per_data_gas > get_data_gasprice(header.excess_data_gas)