Update EIP-4844: reduce size of excess_data_gas to 64 bit
#7095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
Collaborator
|
✅ All reviewers have approved. |
eth-bot
changed the title
excess_data_gas to 64 bitexcess_data_gas to 64 bit
MariusVanDerWijden
previously approved these changes
May 30, 2023
lightclient
force-pushed
the
reduce-edg-size
branch
from
568cb21 to
82af000
Compare
yperbasis
previously approved these changes
May 30, 2023
This was referenced May 30, 2023
g11tech
previously approved these changes
May 31, 2023
Member
Author
|
Approved in CL call 110 |
lightclient
dismissed stale reviews from g11tech, yperbasis, and MariusVanDerWijden
via
b703d35
lightclient
force-pushed
the
reduce-edg-size
branch
from
82af000 to
b703d35
Compare
lightclient
force-pushed
the
reduce-edg-size
branch
from
b703d35 to
f1c34e4
Compare
eth-bot
approved these changes
Jun 2, 2023
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
eth-bot
approved these changes
Jun 2, 2023
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
AlexeyAkhunov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Jun 2, 2023
Implement ethereum/EIPs#7062 and ethereum/EIPs#7095. Pick up ledgerwatch/erigon-lib#1006.
Merged
7 tasks
20 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like an oversight on my part in #5353 to make
excess_blobsa 256 bit unsigned integer and it has propagated through the various changes until now. @karalabe noticed thatexcess_data_gaswill never even need more than a 64 bit unsigned integer. After 1500 blocks, the data fee ends up being around2**256, which is obviously much larger than could possibly be paid.log2(1500*(MAX_DATA_GAS_PER_BLOCK - TARGET_DATA_GAS_PER_BLOCK)) = 28.5, so 64 bit is fine.