Default to SyncManager index if FMMU can't be found #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theol0403
pushed a commit
to theol0403/ethercrab
that referenced
this pull request
Aug 4, 2025
* Change FMMU fallback behaviour to use SM index * Recapture tests * Bump MSRV to 1.81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESI file for the EL3702 describes 3 SMs and 3 FMMUs:
However EtherCrab reads the EEPROM which only reports FMMUs 0 and 2. The previous fallback behaviour was to use the first available inputs or outputs FMMU, but as far as I can see this was a bit too clever and the behaviour should be (can be?) simplified to naively mapping the SM to an FMMU of the same index, whether it exists in the EEPROM or not.
This got my EL3702 into OP with two channels (and no oversampling).
Cc #283