Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.

remove prater config as it has been copied to separate repo#92

Merged
tersec merged 1 commit intoeth-clients:masterfrom
etan-status:rm-prater
Jan 2, 2024
Merged

remove prater config as it has been copied to separate repo#92
tersec merged 1 commit intoeth-clients:masterfrom
etan-status:rm-prater

Conversation

@etan-status
Copy link
Copy Markdown
Contributor

A copy of the prater network definition is also available in the dedicated goerli repo. To avoid having multiple copies of the same data that have to be maintained separately, remove the prater config from this repo.

A copy of the `prater` network definition is also available in the
dedicated `goerli` repo. To avoid having multiple copies of the same
data that have to be maintained separately, remove the `prater` config
from this repo.

- https://github.com/eth-clients/goerli
- eth-clients/goerli#179
@etan-status
Copy link
Copy Markdown
Contributor Author

This is in line with how sepolia / holesky are handled (separate repos).

Mainnet should eventually also be moved to a separate repo, eth2-networks description specifically mentions that this repo is for test networks.

Copy link
Copy Markdown

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@parithosh
Copy link
Copy Markdown
Member

I'll let you merge it once the Nimbus PRs have gone in @etan-status

@etan-status
Copy link
Copy Markdown
Contributor Author

It's fine @parithosh , Nimbus locks all submodules to specific commits, so the version that we locked still contains the prater defs.

For the purpose of tracking what you referred to, this is the PR switching prater to the new goerli repo in Nimbus:

@tersec tersec merged commit e06b6df into eth-clients:master Jan 2, 2024
@etan-status etan-status deleted the rm-prater branch January 2, 2024 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants