Fix raw formatting for big numbers in parameter export and templating by xjules · Pull Request #12535 · equinor/ert

xjules · 2025-12-19T14:33:07Z

Issue
Resolves #12427

Approach
Make sure that the formatting stays raw for integers.
Floats will use notation with :g to keep the current state.

(Screenshot of new behavior in GUI if applicable)

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

codecov-commenter · 2025-12-22T09:56:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.55%. Comparing base (7bdb6d2) to head (0f23f43).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12535      +/-   ##
==========================================
- Coverage   90.58%   90.55%   -0.03%     
==========================================
  Files         435      435              
  Lines       29931    29943      +12     
==========================================
+ Hits        27112    27116       +4     
- Misses       2819     2827       +8

Flag	Coverage Δ
cli-tests	`37.36% <100.00%> (-0.01%)`	⬇️
gui-tests	`68.64% <66.66%> (-0.01%)`	⬇️
performance-and-unit-tests	`73.92% <91.66%> (-0.02%)`	⬇️
test	`38.09% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codspeed-hq · 2025-12-22T16:20:03Z

Merging this PR will not alter performance

Summary

✅ 22 untouched benchmarks

_{Comparing xjules:fix_formatting (0f23f43) with main (a29328d)}

jonathan-eq · 2025-12-22T20:22:24Z

src/ert/run_models/_create_run_path.py

+                if isinstance(value, int):
+                    value_str = str(value)
+                elif isinstance(value, float):
+                    value_str = f"{value:.6g}"


Are we sure we want this at .6g formatting? What will happen if the value is 1234.567464646?

I thought about that and it might get flaky without a precision; ie. .6g means we get always a correct rounding of the number. There are many corner cases though. Extra large and extra small numbers - not sure how realistic they are.

I am not sure this will fix the issue, as the issue is the cornercase when the number is very large. I did some querying and one number submitted by the user was 257382775096236763020404641646935773111

yes, but that is an integer (very likely from the design matrix), which should get a correct handling as integer.

jonathan-eq · 2025-12-22T20:22:42Z

Can we add the test from #12480?

xjules · 2025-12-23T13:07:16Z

We need an extra pair of eyes on this one: @oyvindeide

berland · 2025-12-23T15:44:59Z

We do not want to round as far down as .6g:

>>> aa = 4.2431319809873098109
>>> print(f"{aa:.6g}")
4.24313

I would expect Ert to let me work with double precision floats.

xjules · 2026-01-05T08:49:23Z

We do not want to round as far down as .6g:
>>> aa = 4.2431319809873098109
>>> print(f"{aa:.6g}")
4.24313
I would expect Ert to let me work with double precision floats.

We need to round it for some decimals though; ie. tests, snapshots, etc
So what is the suggestion then?

berland · 2026-01-05T11:13:10Z

We need to round it for some decimals though; ie. tests, snapshots, etc

Rounding for that purpose should be put in the test code.

So what is the suggestion then?

repr(value) or f"{value:.17g}". This will give us round-trip accuracy when going back with float().

xjules · 2026-01-05T13:38:54Z

repr(value)

will not work:

>>> e = 0.000000000000001
>>> repr(e)
'1e-15'

xjules · 2026-01-06T12:50:24Z

Follow up issue with floating precision: #12581

oyvindeide

LGTM, one minor comment.

oyvindeide · 2026-01-07T06:59:15Z

tests/ert/ui_tests/cli/analysis/test_design_matrix.py

                "REAL": list(range(num_realizations)),
                "a": a_values,
                "category": 5 * ["cat1"] + 5 * ["cat2"],
+                "big_numbers": [1e10 + i for i in range(num_realizations)],


Perhaps rename this to big_integer for clarity?

This makes sure that we treat integers in raw format, while floats will remain with the existing scientific notation.

scout-team-app · 2026-01-07T10:37:24Z

Successfully created backport PR for version-18.0:

[Backport version-18.0] Fix raw formatting for big numbers in parameter export and templating #12589

xjules self-assigned this Dec 19, 2025

xjules force-pushed the fix_formatting branch 2 times, most recently from 33ebc62 to 49d268f Compare December 22, 2025 15:41

jonathan-eq reviewed Dec 22, 2025

View reviewed changes

xjules force-pushed the fix_formatting branch from 49d268f to ebd6955 Compare January 6, 2026 11:58

xjules added backport version-18.0 release-notes:bug-fix Automatically categorise as bug fix in release notes labels Jan 6, 2026

xjules force-pushed the fix_formatting branch from ebd6955 to 01363da Compare January 6, 2026 13:51

xjules mentioned this pull request Jan 6, 2026

Fix exporting parameters to runpath for design_matrix uses scientific notation #12480

Closed

9 tasks

xjules force-pushed the fix_formatting branch from 01363da to 9d6fb41 Compare January 6, 2026 14:55

oyvindeide approved these changes Jan 7, 2026

View reviewed changes

Fix raw formatting for big numbers in parameter export and templating

0f23f43

This makes sure that we treat integers in raw format, while floats will remain with the existing scientific notation.

xjules force-pushed the fix_formatting branch from 9d6fb41 to 0f23f43 Compare January 7, 2026 09:39

xjules merged commit a45f33f into equinor:main Jan 7, 2026
35 checks passed

scout-team-app bot mentioned this pull request Jan 7, 2026

[Backport version-18.0] Fix raw formatting for big numbers in parameter export and templating #12589

Merged

Conversation

xjules commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

When applicable

Uh oh!

codecov-commenter commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Summary

Uh oh!

jonathan-eq Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

xjules Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

jonathan-eq Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

xjules Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

jonathan-eq commented Dec 22, 2025

Uh oh!

xjules commented Dec 23, 2025

Uh oh!

berland commented Dec 23, 2025

Uh oh!

xjules commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

berland commented Jan 5, 2026

Uh oh!

xjules commented Jan 5, 2026

Uh oh!

xjules commented Jan 6, 2026

Uh oh!

oyvindeide left a comment

Choose a reason for hiding this comment

Uh oh!

oyvindeide Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scout-team-app bot commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xjules commented Dec 19, 2025 •

edited

Loading

codecov-commenter commented Dec 22, 2025 •

edited

Loading

codspeed-hq bot commented Dec 22, 2025 •

edited

Loading

xjules commented Jan 5, 2026 •

edited

Loading