Conversation
Closed
lidel
reviewed
Oct 7, 2020
| } | ||
| if (protocolType === 'ipfs') { | ||
| externalLink = `https://gateway.ipfs.io/ipfs/${decoded}` | ||
| externalLink = `https://${decoded}.ipfs.dweb.link` // using ipfs's secured origin gateway |
There was a problem hiding this comment.
@makoto please change this to future-proof and canonical https://dweb.link/ipfs/${decoded}
- It will redirect to canonical subdomain, pointing at the same origin no matter if custom base was used (important for cookies and local storage)
- If someone uses CID that can't be represented as a subdomain, they will get useful error instead of DNS failure
- It also keeps content path in URL's pathname, making it easier to copy
lidel
reviewed
Oct 7, 2020
| externalLink = `https://${decoded}.ipfs.dweb.link` // using ipfs's secured origin gateway | ||
| url = `ipfs://${decoded}` | ||
| } else if (protocolType === 'ipns') { | ||
| externalLink = `https://gateway.ipfs.io/ipns/${decoded}` |
There was a problem hiding this comment.
This should also be changed to https://dweb.link/ipns/${decoded} for same reasons as https://github.com/ensdomains/ens-app/pull/936/files#r501146771
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number
#840
ensdomains/ui#46
Screenshots (if appropriate):