secure ipfs gateway#538
Closed
pldespaigne wants to merge 1 commit intoensdomains:devfrom
pldespaigne:ipfs_base32_cid_v1
Closed
secure ipfs gateway#538pldespaigne wants to merge 1 commit intoensdomains:devfrom pldespaigne:ipfs_base32_cid_v1
pldespaigne wants to merge 1 commit intoensdomains:devfrom
pldespaigne:ipfs_base32_cid_v1
Conversation
lidel
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
Yes, you really want to switch to {cid}.ipfs.dweb.link.
It solves the problem raised in MetaMask/metamask-extension#5724 with solution from ipfs/in-web-browsers#89
Both gateway.ipfs.io and .ipfs.dweb.link use the same hosting, so there won't be any difference performance-wise.
lidel
suggested changes
Sep 15, 2020
| } | ||
| if (protocolType === 'ipfs') { | ||
| externalLink = `https://gateway.ipfs.io/ipfs/${decoded}` | ||
| externalLink = `https://${decoded}.ipfs.dweb.link` // using ipfs's secured origin gateway |
There was a problem hiding this comment.
Suggested change
| externalLink = `https://${decoded}.ipfs.dweb.link` // using ipfs's secured origin gateway | |
| externalLink = `https://dweb.link/ipfs/${decoded}` // using ipfs's secured origin gateway |
@makoto
We recommend keeping the path-based router for improved compatibility.
go-ipfs 0.5+ will redirect to correct subdomain, and go-ipfs 0.7+ will even convert CID to DNS-compatible encoding, if the default is too long (eg. if ED25519 key is used in IPNS it will use Base36 to fit in a single DNS label)
Member
|
Duplicate to #936 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello guys 👋 @makoto @Arachnid @jefflau
I have updated the code to resolve ipfs hash trough a secure gateway.
This is a huge security improvement.
This PR has a dependency on this other PR 👇
Everything is detailed on the other PR
As always thanks a lot for your time and your work!
PS : you can read more about secure ipfs in this MetaMask PR