Skip to content

Conversation

@vorburger
Copy link
Member

Fixes #1857 and relates indirectly to #1854.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the Model Context Protocol (MCP) SDK to its latest version, 0.14.1. This update is crucial for resolving specific issues and enhancing the overall architecture by introducing a modular structure to the SDK. The changes involve adapting the existing codebase to consume these new, more focused modules, particularly for JSON handling through Jackson, and updating the build system and documentation to ensure a smooth transition and clear guidance for future development.

Highlights

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully bumps the MCP SDK version from 0.11.3 to 0.14.1. The changes are comprehensive, touching build files, dependency lists, and Java source code to adapt to the new SDK version. The introduction of a singleton ObjectMapper and the consistent use of JacksonMcpJsonMapper are good improvements. The documentation has also been updated to reflect the new dependency update process. Overall, the changes are solid and well-executed. I have one minor suggestion to improve the clarity of the updated documentation.

@vorburger vorburger enabled auto-merge (rebase) October 7, 2025 22:48
@vorburger vorburger merged commit 5ce43d9 into enola-dev:main Oct 7, 2025
14 checks passed
@vorburger vorburger deleted the bump-mcp branch October 7, 2025 22:54
@vorburger
Copy link
Member Author

This actually completely broke MCP... 😭 see #1862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot upgrade (bump) MCP SDK (which is pull transitively via ADK) because of rules_jvm_external problem

1 participant