-
Notifications
You must be signed in to change notification settings - Fork 13
Bump MCP SDK #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MCP SDK #1859
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Model Context Protocol (MCP) SDK to its latest version, 0.14.1. This update is crucial for resolving specific issues and enhancing the overall architecture by introducing a modular structure to the SDK. The changes involve adapting the existing codebase to consume these new, more focused modules, particularly for JSON handling through Jackson, and updating the build system and documentation to ensure a smooth transition and clear guidance for future development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully bumps the MCP SDK version from 0.11.3 to 0.14.1. The changes are comprehensive, touching build files, dependency lists, and Java source code to adapt to the new SDK version. The introduction of a singleton ObjectMapper and the consistent use of JacksonMcpJsonMapper are good improvements. The documentation has also been updated to reflect the new dependency update process. Overall, the changes are solid and well-executed. I have one minor suggestion to improve the clarity of the updated documentation.
|
This actually completely broke MCP... 😭 see #1862. |
Fixes #1857 and relates indirectly to #1854.