-
Notifications
You must be signed in to change notification settings - Fork 13
chore: WIP... too much in 1 go #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a work-in-progress effort to refactor and update the project's dependency management. The primary goals are to transition the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request attempts to update several key dependencies, including ADK and MCP, and switches the Bazel resolver. As you've noted in the title and description, this is a very large set of changes with significant ripple effects across the dependency tree. The update to ADK, in particular, seems to be causing a large number of transitive dependencies to be downgraded, some by multiple major versions. This introduces a high risk of breaking changes, regressions, and pulling in known security vulnerabilities from older library versions. Your plan to break this up into smaller, more gradual pull requests is absolutely the right approach to manage these risks. I've added a specific comment highlighting the extent of the downgrades for visibility.
| com.fasterxml.jackson.core:jackson-annotations:2.13.5 | ||
| com.fasterxml.jackson.core:jackson-core:2.13.5 | ||
| com.fasterxml.jackson.core:jackson-databind:2.19.2 | ||
| com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.19.2 | ||
| com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.19.0 | ||
| com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.19.0 | ||
| com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:2.18.2 | ||
| com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:2.18.2 | ||
| com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.18.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff, and many others in this file, show a significant number of dependency downgrades as a result of the ADK bump. For example:
jackson-coreis downgraded from2.19.2to2.13.5.langchain4j-coreis downgraded from1.6.0to1.4.0.netty-transport-native-epollis downgraded from4.1.116.Finalto4.1.46.Final.tikaartifacts are downgraded from3.0.0to3.0.0-BETA2.
Such major version downgrades can introduce breaking API changes and re-introduce bugs or security vulnerabilities that were fixed in later versions. This highlights the risk of the current approach and strongly supports your plan to break this change into smaller, more manageable pieces to better understand and mitigate the impact of each dependency update.
Relates to #1854 and #1857... but NOK, as is.
Next step: Break this up more gradually, into:
Switch the
resolverofrules_jvm_externalfromcoursiertomavenPin & bump MCP
Bump ADK