Skip to content

Conversation

@vorburger
Copy link
Member

Relates to #1854 and #1857... but NOK, as is.

Next step: Break this up more gradually, into:

  1. Switch the resolver of rules_jvm_external from coursier to maven

  2. Pin & bump MCP

  3. Bump ADK

@vorburger vorburger marked this pull request as draft October 7, 2025 20:54
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents a work-in-progress effort to refactor and update the project's dependency management. The primary goals are to transition the rules_jvm_external resolver to Maven, pin and bump the Model Context Protocol (MCP) library, and update the Google ADK. Additionally, a wide array of other library versions have been adjusted, some to newer releases and others to older, potentially more stable, versions, indicating a broader dependency cleanup and alignment.

Highlights

  • Dependency Resolver Switch: The rules_jvm_external resolver has been switched from coursier to maven in MODULE.bazel and its handlebars template.
  • Google ADK Update: Google ADK dependencies (google-adk, google-adk-dev, google-adk-langchain4j) have been updated and pinned to version e60bddf6502bbfac5af3fb993acc100439c0d90f across MODULE.bazel, MODULE.bom.handlebars.yaml, and docs/dev/dependencies.txt.
  • MCP Integration: The io.modelcontextprotocol.sdk:mcp:0.11.3 dependency has been introduced and explicitly excluded from google-adk and google-adk-langchain4j to prevent potential conflicts, as noted in issue Cannot upgrade (bump) MCP SDK (which is pull transitively via ADK) because of rules_jvm_external problem #1857.
  • Extensive Dependency Version Adjustments: Numerous other dependencies have seen version changes in docs/dev/dependencies.txt, including updates and some downgrades for libraries such as Jackson, Google Cloud APIs, Netty, OpenTelemetry, Apache Tika (to a beta version), and various Apache Commons components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to update several key dependencies, including ADK and MCP, and switches the Bazel resolver. As you've noted in the title and description, this is a very large set of changes with significant ripple effects across the dependency tree. The update to ADK, in particular, seems to be causing a large number of transitive dependencies to be downgraded, some by multiple major versions. This introduces a high risk of breaking changes, regressions, and pulling in known security vulnerabilities from older library versions. Your plan to break this up into smaller, more gradual pull requests is absolutely the right approach to manage these risks. I've added a specific comment highlighting the extent of the downgrades for visibility.

Comment on lines +13 to -21
com.fasterxml.jackson.core:jackson-annotations:2.13.5
com.fasterxml.jackson.core:jackson-core:2.13.5
com.fasterxml.jackson.core:jackson-databind:2.19.2
com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.19.2
com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.19.0
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.19.0
com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:2.18.2
com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:2.18.2
com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.18.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This diff, and many others in this file, show a significant number of dependency downgrades as a result of the ADK bump. For example:

  • jackson-core is downgraded from 2.19.2 to 2.13.5.
  • langchain4j-core is downgraded from 1.6.0 to 1.4.0.
  • netty-transport-native-epoll is downgraded from 4.1.116.Final to 4.1.46.Final.
  • tika artifacts are downgraded from 3.0.0 to 3.0.0-BETA2.

Such major version downgrades can introduce breaking API changes and re-introduce bugs or security vulnerabilities that were fixed in later versions. This highlights the risk of the current approach and strongly supports your plan to break this change into smaller, more manageable pieces to better understand and mitigate the impact of each dependency update.

@vorburger
Copy link
Member Author

Replaced with #1859 and #1861, and later #1860.

@vorburger vorburger closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant