Skip to content

Cleanup some private API and now-unsupported usage #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Cleanup some private API and now-unsupported usage #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b19989a
Remove usage of ComponentLookup
NullVoxPopuli Mar 26, 2025
db15739
Remove more code for now-unsupported embers
NullVoxPopuli Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions addon/src/-internal/build-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import ApplicationInstance from '@ember/application/instance';
import Application from '@ember/application';
import EmberObject from '@ember/object';
import { Registry } from '@ember/-internals/container';
import { ComponentLookup } from '@ember/-internals/views';

import type { FullName } from '@ember/owner';

Expand Down Expand Up @@ -97,9 +96,6 @@ export default function buildRegistry(resolver: Resolver) {

// @ts-ignore: this is private API.
const fallbackRegistry = Application.buildRegistry(namespace);
// TODO: only do this on Ember < 3.13
// @ts-ignore: this is private API.
fallbackRegistry.register('component-lookup:main', ComponentLookup);

const registry = new Registry({
fallback: fallbackRegistry,
Expand Down
15 changes: 0 additions & 15 deletions addon/src/setup-rendering-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import getRootElement from './dom/get-root-element.ts';
import type { Owner } from './build-owner.ts';
import getTestMetadata from './test-metadata.ts';
import { runHooks } from './helper-hooks.ts';
import hasEmberVersion from './has-ember-version.ts';
import isComponent from './-internal/is-component.ts';

// the built in types do not provide types for @ember/template-compilation
Expand Down Expand Up @@ -172,20 +171,6 @@ export function render(
};
toplevelView.setOutletState(outletState);

// Ember's rendering engine is integration with the run loop so that when a run
// loop starts, the rendering is scheduled to be done.
//
// Ember should be ensuring an instance on its own here (the act of
// setting outletState should ensureInstance, since we know we need to
// render), but on Ember < 3.23 that is not guaranteed.
if (!hasEmberVersion(3, 23)) {
// SAFETY: this was correct and type checked on the Ember v3 types, but
// since the `run` namespace does not exist in Ember v4, this no longer
// can be type checked. When (eventually) dropping support for Ember v3,
// and therefore for versions before 3.23, this can be removed entirely.
(run as any).backburner.ensureInstance();
}

// returning settled here because the actual rendering does not happen until
// the renderer detects it is dirty (which happens on backburner's end
// hook), see the following implementation details:
Expand Down