Skip to content

Conversation

@NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Mar 26, 2025

Private APIs I'm not removing, but are tested in ember.js, so we don't accidentally break:

Note:

  • we should have a public API way to build an owner so we can have @ember/test-helpers not use private APIs.
    • would allow us to not use the Mixins
  • I can delete more, but it would technically be a breaking change for this library, I think
    • we have support for custom registries, custom owners, etc... I don't think this makes sense

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 26, 2025 19:43
@NullVoxPopuli NullVoxPopuli changed the title Cleanup some private API usage Cleanup some private API and now-unsupported usage Mar 26, 2025
@kategengler kategengler merged commit d1e36a9 into master Mar 26, 2025
25 checks passed
@kategengler kategengler deleted the nvp/cleanup-legacy-unused branch March 26, 2025 19:51
@github-actions github-actions bot mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants