fix loading race condition #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
force-pushed
the
fix-get-owner-issues
branch
from
ef5c844 to
a9dec4b
Compare
mansona
previously requested changes
Oct 7, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
As discussed in the office hours: I'm not comfortable making a change like this without first doing the work to create multiple test apps that are separate from the ember-inspector code itself
patricklx
force-pushed
the
fix-get-owner-issues
branch
from
a9dec4b to
4db85de
Compare
Collaborator
Author
|
@mansona added a failing test |
patricklx
force-pushed
the
fix-get-owner-issues
branch
6 times, most recently
from
9df396f to
74ef05c
Compare
Collaborator
Author
|
I agree that we need separate tests (happy to pair on this). But i think we should not wait for it to fix current issues. |
NullVoxPopuli
approved these changes
Oct 22, 2025
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
looks good to me -- makes sense -- all the adapter imports are now non-eager
patricklx
force-pushed
the
fix-get-owner-issues
branch
from
f3ff154 to
ebb0432
Compare
patricklx
force-pushed
the
fix-get-owner-issues
branch
from
ebb0432 to
d81cf02
Compare
NullVoxPopuli
approved these changes
Oct 28, 2025
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Thanks for slimming down this PR to just the entrypoints changes!
ef4
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
loadEmberDebugInWebpage needs to wrap the whole loading part. as it was before last release.
this ensures that ember is available before trying to access anything from it.
fixes #2688
Screenshots