Skip to content

Commit d81cf02

Browse files
committed
fix loading race condition
1 parent bd063e0 commit d81cf02

File tree

6 files changed

+36
-17
lines changed

6 files changed

+36
-17
lines changed
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import loadEmberDebugInWebpage from '../lib/load-ember-debug-in-webpage';
2-
import { onEmberReady, startInspector } from '../lib/start-inspector';
32

4-
import adapter from '../adapters/basic';
3+
loadEmberDebugInWebpage(async () => {
4+
const { onEmberReady, startInspector } = await import(
5+
'../lib/start-inspector'
6+
);
57

6-
loadEmberDebugInWebpage(() => onEmberReady(startInspector(adapter)));
8+
const adapter = (await import('../adapters/basic')).default;
9+
onEmberReady(startInspector(adapter));
10+
});
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import loadEmberDebugInWebpage from '../lib/load-ember-debug-in-webpage';
2-
import { onEmberReady, startInspector } from '../lib/start-inspector';
32

4-
import adapter from '../adapters/bookmarklet';
3+
loadEmberDebugInWebpage(async () => {
4+
const { onEmberReady, startInspector } = await import(
5+
'../lib/start-inspector'
6+
);
57

6-
loadEmberDebugInWebpage(() => onEmberReady(startInspector(adapter)));
8+
const adapter = (await import('../adapters/bookmarklet.js')).default;
9+
onEmberReady(startInspector(adapter));
10+
});
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import loadEmberDebugInWebpage from '../lib/load-ember-debug-in-webpage';
2-
import { onEmberReady, startInspector } from '../lib/start-inspector';
32

4-
import adapter from '../adapters/chrome';
3+
loadEmberDebugInWebpage(async () => {
4+
const { onEmberReady, startInspector } = await import(
5+
'../lib/start-inspector'
6+
);
57

6-
loadEmberDebugInWebpage(() => onEmberReady(startInspector(adapter)));
8+
const adapter = (await import('../adapters/chrome.js')).default;
9+
onEmberReady(startInspector(adapter));
10+
});
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import loadEmberDebugInWebpage from '../lib/load-ember-debug-in-webpage';
2-
import { onEmberReady, startInspector } from '../lib/start-inspector';
32

4-
import adapter from '../adapters/firefox';
3+
loadEmberDebugInWebpage(async () => {
4+
const { onEmberReady, startInspector } = await import(
5+
'../lib/start-inspector'
6+
);
57

6-
loadEmberDebugInWebpage(() => onEmberReady(startInspector(adapter)));
8+
const adapter = (await import('../adapters/firefox.js')).default;
9+
onEmberReady(startInspector(adapter));
10+
});
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import loadEmberDebugInWebpage from '../lib/load-ember-debug-in-webpage';
2-
import { onEmberReady, startInspector } from '../lib/start-inspector';
32

4-
import adapter from '../adapters/websocket';
3+
loadEmberDebugInWebpage(async () => {
4+
const { onEmberReady, startInspector } = await import(
5+
'../lib/start-inspector'
6+
);
57

6-
loadEmberDebugInWebpage(() => onEmberReady(startInspector(adapter)));
8+
const adapter = (await import('../adapters/websocket.js')).default;
9+
onEmberReady(startInspector(adapter));
10+
});

tests/integration/injection-test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@ module('Integration | Injection', function (hooks) {
238238
// check that we do not have any errors
239239
await new Promise((resolve, reject) => {
240240
window.addEventListener('error', reject);
241-
// eslint-disable-next-line no-undef
242-
chrome.runtime.onMessage.addListener((message) => {
241+
contentChromeApi.runtime.onMessage.addListener((message) => {
243242
if (message?.type === 'inject-ember-debug') {
244243
setTimeout(resolve, 200);
245244
}

0 commit comments

Comments
 (0)