Skip to content

Fix negative parameter behavior #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Fix negative parameter behavior #3062

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac240b8
Fix negative parameter behavior
Jan 3, 2023
4b5e50a
Remove unnecessary extra code
Jan 4, 2023
2f6d893
Merge branch 'v3.14.x' of ssh://github.com/elyra-ai/elyra into neg-param
akchinSTC Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/ui-components/src/FormDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,9 @@ const preventDefaultDialogHandler = (
// Returns true if given element is valid
const isFieldValid = (element: any): boolean => {
if (element.type === 'number') {
const ifRequiredHasValue = element.hasAttribute('data-form-required')
return element.hasAttribute('data-form-required')
? element.value !== ''
: true;
const validNumber = Number(element.value.trim()) >= 0;
return ifRequiredHasValue && validNumber;
}
return element.value.trim() ? true : false;
};
Expand Down