Skip to content

Conversation

@marthacryan
Copy link
Member

Fixes #3061 - changes behavior to allow any numbers as input, not sure why we added that but it was added in #3001.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Martha Cryan <[email protected]>
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As advertised
image

Signed-off-by: Martha Cryan <[email protected]>
@ptitzler ptitzler added this to the 3.14.2 milestone Jan 5, 2023
@ptitzler ptitzler added kind:bug Something isn't working component:pipeline-editor pipeline editor labels Jan 5, 2023
@ptitzler
Copy link
Member

ptitzler commented Jan 5, 2023

It appears that there's also a type checking problem. One can enter a floating point value (e.g. 88.9 or -77.8) for Integer-typed parameters

image

, which results in invalid code generation - the parameter value is missing.

image

This is what the genefrated code looks like for valid Integer input

image

@akchinSTC akchinSTC merged commit ce071dd into elyra-ai:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:pipeline-editor pipeline editor kind:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipeline parameter type integer or float cannot take negative number as input

3 participants