Added before_destroy filter to the commentable model #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem when deleting the commentable model. The :dependent => :destroy clause tries to destroy all comments leading to an error because each comment also destroys its child comments, resulting in the commentable model trying to destroy an unexisting child comment.
The solution is to replace the :dependent => :destroy clause for a before_destroy filter only afecting the root comments:
rubybefore_destroy { |record| record.root_comments.destroy_all }