order comment threads explicitly and only fetch root comments #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, destroying the commentable object occasionally would fail because awesome_nested_set had already deleted records by lft/right and could not find them on reload_nested_set.
|
this will stop displaying nested comments |
Author
|
close in favor of #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem in our app: Destroying a commentable record did invoke all the :destroy hooks by the
has_many :comment_threadsbut under certian circumstances it tried to load records it already deleted before. My first guess was the undeterministic order of deletion, but even then it happened.My seconds guess aimed towards the tree structure. If awesome_nested_set cares about deletion of descendents,
:comment_threadsonly has to return itsrootsand letanswork from there.So here it is, works OK for us :)