Support the new /auth_metadata endpoint defined in MSC2965.#18093
Merged
Support the new /auth_metadata endpoint defined in MSC2965.#18093
/auth_metadata endpoint defined in MSC2965.#18093Conversation
anoadragon453
approved these changes
Jan 21, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Some small nits and a question, but otherwise looks good!
(Would be nice to see some Complement tests for all this at some point at well.)
Comment on lines
+118
to
+125
| req_mock = AsyncMock( | ||
| return_value={ | ||
| "issuer": ISSUER, | ||
| "authorization_endpoint": "https://example.com/auth", | ||
| "token_endpoint": "https://example.com/token", | ||
| } | ||
| ) | ||
| self.hs.get_proxied_http_client().get_json = req_mock # type: ignore[method-assign] |
Member
There was a problem hiding this comment.
This is mocking a request Synapse is supposed to be making externally, right? This one?
synapse/synapse/api/auth/msc3861_delegated.py
Line 145 in ca290d3
Just checking that we're not mocking the test http client and then immediately checking it returns the mocked data.
Member
Author
There was a problem hiding this comment.
Yep, that's what's happening
Co-authored-by: Andrew Morgan <[email protected]>
turt2live
reviewed
Jan 22, 2025
Comment on lines
+95
to
+99
| raise SynapseError( | ||
| 404, | ||
| "OIDC discovery has not been configured on this homeserver", | ||
| Codes.NOT_FOUND, | ||
| ) |
Member
There was a problem hiding this comment.
Spec would prefer M_UNRECOGNIZED with 404. https://spec.matrix.org/v1.13/client-server-api/#common-error-codes
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the updated MSC2965