Redesign widget pip and move into shared component#32654
Conversation
709f311 to
dd790b9
Compare
ff640d9 to
6bacdd9
Compare
| width: 304px; /* from $width */ | ||
| height: 278px; /* from $height */ |
There was a problem hiding this comment.
$width and $height is unknown in SC. Is it referring something in EW?
There was a problem hiding this comment.
Yes we should remove that comment.
There was a problem hiding this comment.
I think (to not block this on CI again) i will create a new PR with this comment cleanup + the renaming of the RoomHeaderBar file that was pointed out during the review.
| @@ -0,0 +1,108 @@ | |||
| /* | |||
| * Copyright (c) 2025 Element Creations Ltd. | |||
There was a problem hiding this comment.
I just decided to put this into this PR and not over to the other one I was mentioning here:
I think (to not block this on CI again) i will create a new PR with this comment cleanup + the renaming of the RoomHeaderBar file that was pointed out during the review.
There was a problem hiding this comment.
So one more round of CI
BillCarsonFr
left a comment
There was a problem hiding this comment.
Thx 🙏, can't wait to test it.
just some minor comments on the headers
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2025 Element Creations Ltd. | |||
| * Copyright (c) 2026 Element Creations Ltd. | |||
There was a problem hiding this comment.
I think for this PR this is okay since its no diff to what it was before.
I will do the follow up PR. There we can update it if 2025, 2026 is the expected text.
Fixes: #20383
Fixes: #32479
Related EC PR: element-hq/element-call#3775
copied from EC PR:
pointer-events: none(we have the header now so it is acceptable to interact with the widget while in pip)mx_NAMEclass namesWARNING:
We might want to block this PR on EC v0.18.0. We will loose the ability to hangup in pip mode with v0.17.0 and this PR merged (which is not the worst that could happen but also not idea.) (the workaround is: press the back button -> press the hangup button)
Checklist
public/exportedsymbols have accurate TSDoc documentation.