Skip to content

Redesign widget pip and move into shared component#32654

Merged
toger5 merged 25 commits intodevelopfrom
toger5/pip-widget-view-shared-component-redesign
Mar 10, 2026
Merged

Redesign widget pip and move into shared component#32654
toger5 merged 25 commits intodevelopfrom
toger5/pip-widget-view-shared-component-redesign

Conversation

@toger5
Copy link
Copy Markdown
Contributor

@toger5 toger5 commented Feb 26, 2026

Fixes: #20383
Fixes: #32479

Related EC PR: element-hq/element-call#3775
copied from EC PR:

Screenshots / GIFs

Before After
Screenshot 2026-03-10 at 11 12 00 Screenshot 2026-03-10 at 11 14 27 Screenshot 2026-03-10 at 11 15 46

(The bottom after image is on hover)
Be aware that this is WIHTOUT the associated EW changes!
-> This just proves that things are not completely broken in case we fail on shipping them simultaneously.

With EW patches:

Before After
Screenshot 2026-03-10 at 11 23 50 Screenshot 2026-03-10 at 11 22 29Screenshot 2026-03-10 at 11 22 34

Proving that things are not broken in case we fail on shipping them simultaneously.

  • Add shared component for widgetPip
    • Using two different ways to pass subcomponents
      • for the avatar we just accept a react component that can be passed via a prop (this allow to give every component its own avatar)
      • for the PersistentWidget we pass the subcomponent via the viewmodel. The component is static. We basically just want to expose PersistenWidget type through the viewModel.
  • remove pointer-events: none (we have the header now so it is acceptable to interact with the widget while in pip)
  • remove hover logic for pip.
  • adapt tests to use testid instead of deprecated mx_NAME class names
  • checked that this works with jisti

WARNING:
We might want to block this PR on EC v0.18.0. We will loose the ability to hangup in pip mode with v0.17.0 and this PR merged (which is not the worst that could happen but also not idea.) (the workaround is: press the back button -> press the hangup button)

Checklist

@toger5 toger5 added the T-Feature Request to add a new feature which does not exist right now label Feb 26, 2026
@toger5 toger5 added T-Enhancement and removed T-Feature Request to add a new feature which does not exist right now labels Feb 27, 2026
@toger5 toger5 force-pushed the toger5/pip-widget-view-shared-component-redesign branch from 709f311 to dd790b9 Compare February 27, 2026 11:26
@toger5 toger5 force-pushed the toger5/pip-widget-view-shared-component-redesign branch from ff640d9 to 6bacdd9 Compare February 27, 2026 11:52
Comment on lines +9 to +10
width: 304px; /* from $width */
height: 278px; /* from $height */
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$width and $height is unknown in SC. Is it referring something in EW?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should remove that comment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (to not block this on CI again) i will create a new PR with this comment cleanup + the renaming of the RoomHeaderBar file that was pointed out during the review.

@toger5 toger5 enabled auto-merge March 10, 2026 15:54
@toger5 toger5 disabled auto-merge March 10, 2026 15:54
@@ -0,0 +1,108 @@
/*
* Copyright (c) 2025 Element Creations Ltd.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just decided to put this into this PR and not over to the other one I was mentioning here:

I think (to not block this on CI again) i will create a new PR with this comment cleanup + the renaming of the RoomHeaderBar file that was pointed out during the review.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one more round of CI

Copy link
Copy Markdown
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 🙏, can't wait to test it.
just some minor comments on the headers

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2025 Element Creations Ltd.
* Copyright (c) 2026 Element Creations Ltd.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2025, 2026?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this PR this is okay since its no diff to what it was before.

I will do the follow up PR. There we can update it if 2025, 2026 is the expected text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ER-188] Alternative layout for widget PIP view Different initial PiP position (on develop.element.io)

3 participants