Implement new Pip Layout (with control buttons)#3775
Conversation
ae5a0ee to
cb8e96a
Compare
fc81669 to
45fc6ad
Compare
There was a problem hiding this comment.
Ok, but need a playwright test.
Test for the visibility of the footer button. and test they are interactive. See this test for setting up the pip https://github.com/element-hq/element-call/blob/livekit/playwright/widget/pip-call.test.ts
I am noticing that those tests are not super useful yet. Since we will still have the overlay, we are not able to click the buttons without bumping EW. On top I created tests checking that we can press the buttons (that there is nothing blocking the clicks) in EW. |
But as soon as the web PR will be merged it will be fine, right? Meanwhile the test can be ran on HOST=https://pr32654--matrix-react-sdk.netlify.app/ |
45fc6ad to
6485da8
Compare
|
I now went with a test that only checks for the visibility of those buttons. Clicking is commented out for now see: |
|
@BillCarsonFr Does this justify merging the PR as is? #3794 |
7f325d1 to
3a9d394
Compare
Fixes: https://github.com/element-hq/voip-internal/issues/488
Also fixes: #3620
copied upcoming PR Template
Content
Update the desktop pip call layout:
This allows us to achive the UX described here: https://github.com/element-hq/voip-internal/issues/488
Motivation and context
We want to update the UX for pip:
Screenshots / GIFs
(The bottom after image is on hover)
Be aware that this is WIHTOUT the associated EW changes!
-> This just proves that things are not completely broken in case we fail on shipping them simultaneously.
With EW patches:
Proving that things are not broken in case we fail on shipping them simultaneously.
Tests
Checklist
I have read through CONTRIBUTING.md.
Pull request includes screenshots or videos if containing UI changes
Tests written for new code (and old code if feasible).
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)
test on mobile (dont regress mobile pip)