Fix some error log lines that lead to confusion by toger5 · Pull Request #3679 · element-hq/element-call

toger5 · 2026-01-16T09:52:24Z

In the past those log lines often were referenced for issues but they are no real issues.
Either they are just deprecated code running or expected.

toger5 · 2026-01-16T13:48:25Z

This PR increases the overall coverage and already introduces a not super helpful test (for a log line on error)

So I will merge it with failing CI once approved!

BillCarsonFr · 2026-01-16T16:44:56Z

src/room/InCallView.tsx

    [vm],
  );

-  useEffect(() => {


This doesn't match the PR description. This will lead to confusion in the future when looking at history

Do you want to split this into two PR's? Or update the title.
I think the PR can stay as one cleanup PR. That removes outdated code that causes unwanted logs and also improve logs.

Sth like:
Remove outdated layout widget api messages (reduce and improve error logs)

why is this outdated? This is now directly inside EC?
That means that ElementWidgetActions.TileLayout should be deprecated?

BillCarsonFr · 2026-01-16T16:47:25Z

src/state/CallViewModel/localMember/LocalMember.test.ts

    });
  });

+  it("logs if callIntent cannot be updated", async () => {


It is indeed testing the code, but looks like the code is talking to us? why are we trying to update call intent if not connected? I also find it strange that the intent is mutable :/ causes traffic everytime you mute/unmute camera

I also played with checking if we are connected here. But it was somewhat redundant. if we already have a check in the js-sdk if we are connected.

BillCarsonFr

It looks to me that this PR is doing 2 different things?

One is removing deprecated(?) widget actions
The other about error logs confusion(?)

I'd prefer we ~~merge it~~ split in 2 PRs

BillCarsonFr · 2026-01-16T17:23:10Z

src/room/InCallView.tsx

    [vm],
  );

-  useEffect(() => {


why is this outdated? This is now directly inside EC?
That means that ElementWidgetActions.TileLayout should be deprecated?

toger5 · 2026-01-19T08:41:19Z

I'd prefer we merge it

split it into two PRs?

toger5 · 2026-01-19T08:42:04Z

why is this outdated

It was designed in a way where the layout switch buttons were part of the element web header bar.
Now (as you said) its inside the iframe. So the action is not needed anymore.

BillCarsonFr · 2026-01-19T08:42:40Z

I'd prefer we merge it

split it into two PRs?

YES

In the past those log lines often were referenced for issues but they are no real issues. Either they are just deprecated code running or expected.

toger5 · 2026-01-19T11:21:30Z

@BillCarsonFr I have split this:

This PR
And this one: Remove deprecated widget layout actions #3689

BillCarsonFr · 2026-01-19T12:18:46Z

src/room/InCallView.tsx

    [vm],
  );

-  useEffect(() => {


this is now in https://github.com/element-hq/element-call/pull/3689/changes? no

BillCarsonFr · 2026-01-19T12:24:55Z

src/state/CallViewModel/localMember/LocalTransport.ts

      if (ex instanceof MatrixError && ex.httpStatus === 404) {
        // Expected, this is an unstable endpoint and it's not required.
-        logger.debug("Backend does not provide any RTC transports", ex);
+        logger.debug(


This a bit strange for a log no? looks lie it is a user facing string.
Maybe keep the old log and add that as a comment?

BillCarsonFr

OK, to merge.
It looks like the line markes as not covered by codecov are actually covered by this test Creating preferred transport based?
That is strange, ok to force merge

github-actions bot deployed to Netlify January 16, 2026 09:53 View deployment

toger5 added the PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository. label Jan 16, 2026

github-actions bot deployed to Netlify January 16, 2026 10:01 View deployment

github-actions bot deployed to Netlify January 16, 2026 10:10 View deployment

toger5 marked this pull request as ready for review January 16, 2026 10:11

toger5 requested a review from a team as a code owner January 16, 2026 10:11

toger5 requested a review from BillCarsonFr January 16, 2026 10:11

github-actions bot deployed to Netlify January 16, 2026 10:11 View deployment

github-actions bot deployed to Netlify January 16, 2026 11:27 View deployment

github-actions bot deployed to Netlify January 16, 2026 12:03 View deployment

toger5 force-pushed the toger5/fix-unnecassary-error-logs branch from 032d5bb to b9f2ec3 Compare January 16, 2026 12:07

github-actions bot deployed to Netlify January 16, 2026 12:08 View deployment

toger5 mentioned this pull request Jan 16, 2026

Fix Publisher cleanup procedure #3675

Merged

1 task

BillCarsonFr requested changes Jan 16, 2026

View reviewed changes

toger5 requested a review from BillCarsonFr January 19, 2026 08:36

BillCarsonFr requested changes Jan 19, 2026

View reviewed changes

toger5 force-pushed the toger5/fix-unnecassary-error-logs branch from b9f2ec3 to 1e6114e Compare January 19, 2026 11:12

github-actions bot deployed to Netlify January 19, 2026 11:13 View deployment

Fix some error log lines that lead to confusion.

a102b3f

In the past those log lines often were referenced for issues but they are no real issues. Either they are just deprecated code running or expected.

toger5 force-pushed the toger5/fix-unnecassary-error-logs branch from 1e6114e to a102b3f Compare January 19, 2026 11:20

github-actions bot deployed to Netlify January 19, 2026 11:22 View deployment

toger5 requested a review from BillCarsonFr January 19, 2026 11:55

BillCarsonFr reviewed Jan 19, 2026

View reviewed changes

toger5 added 2 commits January 19, 2026 13:54

remove leftover layout action code

94bcb1b

better log msg

a7008d3

toger5 requested a review from BillCarsonFr January 19, 2026 12:55

github-actions bot deployed to Netlify January 19, 2026 12:56 View deployment

BillCarsonFr approved these changes Jan 19, 2026

View reviewed changes

toger5 merged commit a72aae0 into livekit Jan 19, 2026
32 of 34 checks passed

Conversation

toger5 commented Jan 16, 2026

Uh oh!

toger5 commented Jan 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toger5 commented Jan 19, 2026

Uh oh!

toger5 commented Jan 19, 2026

Uh oh!

BillCarsonFr commented Jan 19, 2026

Uh oh!

toger5 commented Jan 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BillCarsonFr left a comment •

edited

Loading