Conversation
kind of switches!) Optimize to not always fetch the oldest member jwt (only do so in legacy mode)
toger5
changed the title
| [vm], | ||
| ); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
why is this related to current issue?
There was a problem hiding this comment.
Its not. And also done by this PR: #3679
I was hoping it will resolve itself on merge. But this ^ too longer to get approved.
| } | ||
| }, | ||
| (scope, _data$, serviceUrl, alias, sfuConfig) => { | ||
| logger.debug( |
There was a problem hiding this comment.
No it was duplicated with the log inside the constructor of the connection.
The one inside the constructor also had better scoping [Connection <url>]
src/widget.ts
Outdated
| EventType.RoomRedaction, | ||
| ElementCallReactionEventType, | ||
| EventType.RTCDecline, | ||
| EventType.RTCMembership, // Send/Read the membership sticky events |
There was a problem hiding this comment.
No. And robin will look into this properly. Its also just the event type and not the new sticky capability. So lets not touch this in this PR.
There was a problem hiding this comment.
Its reverted in this PR now.
dev-backend-docker-compose.yml
Outdated
| services: | ||
| auth-service: | ||
| image: ghcr.io/element-hq/lk-jwt-service:sha-f8ddd00 | ||
| image: ghcr.io/element-hq/lk-jwt-service:0.4.1 |
There was a problem hiding this comment.
I thought its better to have the stable version. And 0.4.1 is very new and also supports both endpoints. It just does not support delegation. Which we do not really test yet (and also do not have to support. Its optional spec basically.)
In other words: you are fully supporting matrix2.0 even if you do not use the delegation feature.
There was a problem hiding this comment.
I wonder how we could test different versions :/
Or maybe we could have renovate to create a PR for new releases?
2 participants
Fixes: https://github.com/element-hq/voip-internal/issues/444#event-22090544135
This will get a separate playwright test reproducing the issue, that this fixes (in a seperate PR)
oldest_member(singeSFU) tomulti_sfu) #3681