Skip to content

Ignore flaky test "CantVerifyTest" and "fix" VoiceRecorderLTests#7222

Merged
bmarty merged 2 commits intodevelopfrom
feature/bma/ignore_flaky_test
Sep 23, 2022
Merged

Ignore flaky test "CantVerifyTest" and "fix" VoiceRecorderLTests#7222
bmarty merged 2 commits intodevelopfrom
feature/bma/ignore_flaky_test

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Sep 23, 2022

To give us time to work on it and unblock other PRs so they can be merged.

@bmarty bmarty requested review from mnaturel and ouchadam September 23, 2022 09:49
@bmarty bmarty enabled auto-merge September 23, 2022 09:53
@jmartinesp
Copy link
Copy Markdown
Member

It seems like changing the test order in VoiceRecorderL didn't really fix the issue? I could try creating a PR that fixes this by not using the actual OggOpusEncoder but a fake one, but for that I'd need to also make some new changes to its implementation here, since mockk can't actually mock external funs.

@bmarty bmarty force-pushed the feature/bma/ignore_flaky_test branch from 9c42b87 to 97b3b23 Compare September 23, 2022 12:09
@bmarty
Copy link
Copy Markdown
Member Author

bmarty commented Sep 23, 2022

Yes, strange, on this PR #7197 it seems to be fixed. Let's just ignore the test here. I have force pushed the branch.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmarty bmarty merged commit 4631135 into develop Sep 23, 2022
@bmarty bmarty deleted the feature/bma/ignore_flaky_test branch September 23, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants